make_corefile_notes: have caller free returned memory

The various make_corefile_notes implementations for gdbarch as well as target
currently make an xfree cleanup on the data they return.  This causes problems
when trying to put a TRY_CATCH around the make_corefile_notes call.
Specifically, we get a stale cleanup error in restore_my_cleanups.

Omit the make_cleanup and have the caller free the memory.

gdb/
	* fbsd-nat.c (fbsd_make_corefile_notes): Remove make_cleanup call.
	* gcore.c (write_gcore_file): Free memory returned from
	make_corefile_notes.
	* linux-tdep.c (linux_make_corefile_notes): Remove make_cleanup call.
	* procfs.c (procfs_make_note_section): Remove make_cleanup call.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 44e85753417e0ff1e3b8c5175a85824edf923ac0..a56ec40364b9040d30f17a5827a213bbf0dcef9e 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,11 @@
+2014-06-25  Markus Metzger  <markus.t.metzger@intel.com>
+
+       * fbsd-nat.c (fbsd_make_corefile_notes): Remove make_cleanup call.
+       * gcore.c (write_gcore_file): Free memory returned from
+       make_corefile_notes.
+       * linux-tdep.c (linux_make_corefile_notes): Remove make_cleanup call.
+       * procfs.c (procfs_make_note_section): Remove make_cleanup call.
+
 2014-06-24  Yao Qi  <yao@codesourcery.com>
 
        * arm-linux-tdep.c (arm_linux_skip_trampoline_code): New.

diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c
index 9f30edf4b27b997f3ed9c71e562a9ea7eece4efd..4e115b276f8af519dfca7acb39947f7b3530c37c 100644 (file)
--- a/gdb/fbsd-nat.c
+++ b/gdb/fbsd-nat.c
@@ -214,6 +214,5 @@ fbsd_make_corefile_notes (struct target_ops *self, bfd *obfd, int *note_size)
                                          fname, psargs);
     }
 
-  make_cleanup (xfree, note_data);
   return note_data;
 }

diff --git a/gdb/gcore.c b/gdb/gcore.c
index e22508010012e466e7a05d35bb68e9941b165239..5427962be08dfa97d24f4de96abe9bb074d93d83 100644 (file)
--- a/gdb/gcore.c
+++ b/gdb/gcore.c
@@ -68,6 +68,7 @@ create_gcore_bfd (const char *filename)
 void
 write_gcore_file (bfd *obfd)
 {
+  struct cleanup *cleanup;
   void *note_data = NULL;
   int note_size = 0;
   asection *note_sec = NULL;
@@ -81,6 +82,8 @@ write_gcore_file (bfd *obfd)
   else
     note_data = gdbarch_make_corefile_notes (target_gdbarch (), obfd, &note_size);
 
+  cleanup = make_cleanup (xfree, note_data);
+
   if (note_data == NULL || note_size == 0)
     error (_("Target does not support core file generation."));
 
@@ -104,6 +107,8 @@ write_gcore_file (bfd *obfd)
   /* Write out the contents of the note section.  */
   if (!bfd_set_section_contents (obfd, note_sec, note_data, 0, note_size))
     warning (_("writing note section (%s)"), bfd_errmsg (bfd_get_error ()));
+
+  do_cleanups (cleanup);
 }
 
 static void

diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c
index ca19cf459be81af06ea1803b3efc25d7b4c6cb12..d0f1106ce85daef51bd00175155a0c5b46f7dfdf 100644 (file)
--- a/gdb/linux-tdep.c
+++ b/gdb/linux-tdep.c
@@ -1502,7 +1502,6 @@ linux_make_corefile_notes (struct gdbarch *gdbarch, bfd *obfd, int *note_size,
   note_data = linux_make_mappings_corefile_notes (gdbarch, obfd,
                                                  note_data, note_size);
 
-  make_cleanup (xfree, note_data);
   return note_data;
 }
 

diff --git a/gdb/procfs.c b/gdb/procfs.c
index cbb44ce60de3122dc2d5cdbe30845e7a40e8c2a5..4caaf7b3483ea26e15a3e8a68c237da3edac8694 100644 (file)
--- a/gdb/procfs.c
+++ b/gdb/procfs.c
@@ -5522,7 +5522,6 @@ procfs_make_note_section (struct target_ops *self, bfd *obfd, int *note_size)
       xfree (auxv);
     }
 
-  make_cleanup (xfree, note_data);
   return note_data;
 }
 #else /* !Solaris */