x86: properly force / avoid forcing EVEX encoding

Pseudo prefixes are supposed to be a hint only - when the specific
encoding can't be used to encode an insn, silently override it. But
this overriding must only happen after the respective check, to
avoid forcing EVEX encoding because of something that isn't a valid
register name in the given context.

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 7981f81cf61be646da1828036e24a1b8c0643e6e..0462a802bd378373b0ca9c1760fbd2485301c20f 100644 (file)
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,14 @@
+2018-04-26  Jan Beulich  <jbeulich@suse.com>
+
+       * config/tc-i386.c (parse_real_register): Check .cpuvrex before
+       recording EVEX encoding. Don't check previously specified
+       encoding.
+       * testsuite/gas/i386/xmmhi32.s: Add {x,y,z}mm{16,24} cases.
+       * testsuite/gas/i386/xmmhi32.d: Adjust expectations.    
+       * testsuite/gas/i386/xmmhi64.s, testsuite/gas/i386/xmmhi64.d:
+       New.
+       * testsuite/gas/i386/i386.exp: Run new test.
+
 2018-04-26  Jan Beulich  <jbeulich@suse.com>
 
        * testsuite/gas/i386/xsave.s: Add AVX, LWP, MPX, and PKU

diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c
index 723fc3e6c2e840f4e795552377ef85475e21ac44..a48cfc2fc9f475b5e3b05b25473b8935bf7ad9c6 100644 (file)
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -10180,17 +10180,15 @@ parse_real_register (char *reg_string, char **end_op)
       && (r->reg_num == RegEiz || r->reg_num == RegRiz))
     return (const reg_entry *) NULL;
 
-  /* Upper 16 vector register is only available with VREX in 64bit
-     mode.  */
-  if ((r->reg_flags & RegVRex))
+  /* Upper 16 vector registers are only available with VREX in 64bit
+     mode, and require EVEX encoding.  */
+  if (r->reg_flags & RegVRex)
     {
-      if (i.vec_encoding == vex_encoding_default)
-       i.vec_encoding = vex_encoding_evex;
-
       if (!cpu_arch_flags.bitfield.cpuvrex
-         || i.vec_encoding != vex_encoding_evex
          || flag_code != CODE_64BIT)
        return (const reg_entry *) NULL;
+
+      i.vec_encoding = vex_encoding_evex;
     }
 
   if (((r->reg_flags & (RegRex64 | RegRex))

diff --git a/gas/testsuite/gas/i386/i386.exp b/gas/testsuite/gas/i386/i386.exp
index 8bbe10088f579b9920ca4e8809e2b8d9f0c53dfd..e061c67fbe240b14839aa6d6b28045754c08b377 100644 (file)
--- a/gas/testsuite/gas/i386/i386.exp
+++ b/gas/testsuite/gas/i386/i386.exp
@@ -692,6 +692,7 @@ if [expr ([istarget "i*86-*-*"] || [istarget "x86_64-*-*"]) && [gas_64_check]] t
     run_dump_test "x86-64-arch-2-btver2"
     run_list_test "x86-64-arch-2-1" "-march=generic64 -I${srcdir}/$subdir -al"
     run_list_test "x86-64-arch-2-2" "-march=generic64+cx16 -I${srcdir}/$subdir -al"
+    run_dump_test "xmmhi64"
     run_dump_test "x86-64-xsave"
     run_dump_test "x86-64-xsave-intel"
     run_dump_test "x86-64-aes"

diff --git a/gas/testsuite/gas/i386/xmmhi32.d b/gas/testsuite/gas/i386/xmmhi32.d
index b3ba7a3be522d1ac277c81bddf8d5ff91accea0b..fd46af6c369e3d5bcd3b53d5ac328e2f0e96bde0 100644 (file)
--- a/gas/testsuite/gas/i386/xmmhi32.d
+++ b/gas/testsuite/gas/i386/xmmhi32.d
@@ -7,21 +7,41 @@ Disassembly of section .text:
 
 0+ <xmm>:
 [      ]*[a-f0-9]+:    c5 f0 58 05 00 00 00 00         vaddps 0x0,%xmm1,%xmm0  [a-f0-9]+: R_386_32     xmm8
+[      ]*[a-f0-9]+:    c5 f0 58 05 00 00 00 00         vaddps 0x0,%xmm1,%xmm0  [a-f0-9]+: R_386_32     xmm16
+[      ]*[a-f0-9]+:    c5 f0 58 05 00 00 00 00         vaddps 0x0,%xmm1,%xmm0  [a-f0-9]+: R_386_32     xmm24
 [      ]*[a-f0-9]+:    c5 f4 58 05 00 00 00 00         vaddps 0x0,%ymm1,%ymm0  [a-f0-9]+: R_386_32     ymm8
+[      ]*[a-f0-9]+:    c5 f4 58 05 00 00 00 00         vaddps 0x0,%ymm1,%ymm0  [a-f0-9]+: R_386_32     ymm16
+[      ]*[a-f0-9]+:    c5 f4 58 05 00 00 00 00         vaddps 0x0,%ymm1,%ymm0  [a-f0-9]+: R_386_32     ymm24
 [      ]*[a-f0-9]+:    62 f1 74 48 58 05 00 00 00 00   vaddps 0x0,%zmm1,%zmm0  [a-f0-9]+: R_386_32     zmm8
 [      ]*[a-f0-9]+:    62 f1 74 48 58 05 00 00 00 00   vaddps 0x0,%zmm1,%zmm0  [a-f0-9]+: R_386_32     zmm16
 [      ]*[a-f0-9]+:    62 f1 74 48 58 05 00 00 00 00   vaddps 0x0,%zmm1,%zmm0  [a-f0-9]+: R_386_32     zmm24
 [      ]*[a-f0-9]+:    c5 f9 6f 05 00 00 00 00         vmovdqa 0x0,%xmm0       [a-f0-9]+: R_386_32     xmm8
+[      ]*[a-f0-9]+:    c5 f9 6f 05 00 00 00 00         vmovdqa 0x0,%xmm0       [a-f0-9]+: R_386_32     xmm16
+[      ]*[a-f0-9]+:    c5 f9 6f 05 00 00 00 00         vmovdqa 0x0,%xmm0       [a-f0-9]+: R_386_32     xmm24
 [      ]*[a-f0-9]+:    c5 fd 6f 05 00 00 00 00         vmovdqa 0x0,%ymm0       [a-f0-9]+: R_386_32     ymm8
+[      ]*[a-f0-9]+:    c5 fd 6f 05 00 00 00 00         vmovdqa 0x0,%ymm0       [a-f0-9]+: R_386_32     ymm16
+[      ]*[a-f0-9]+:    c5 fd 6f 05 00 00 00 00         vmovdqa 0x0,%ymm0       [a-f0-9]+: R_386_32     ymm24
 [      ]*[a-f0-9]+:    c5 f9 7f 05 00 00 00 00         vmovdqa %xmm0,0x0       [a-f0-9]+: R_386_32     xmm8
+[      ]*[a-f0-9]+:    c5 f9 7f 05 00 00 00 00         vmovdqa %xmm0,0x0       [a-f0-9]+: R_386_32     xmm16
+[      ]*[a-f0-9]+:    c5 f9 7f 05 00 00 00 00         vmovdqa %xmm0,0x0       [a-f0-9]+: R_386_32     xmm24
 [      ]*[a-f0-9]+:    c5 fd 7f 05 00 00 00 00         vmovdqa %ymm0,0x0       [a-f0-9]+: R_386_32     ymm8
+[      ]*[a-f0-9]+:    c5 fd 7f 05 00 00 00 00         vmovdqa %ymm0,0x0       [a-f0-9]+: R_386_32     ymm16
+[      ]*[a-f0-9]+:    c5 fd 7f 05 00 00 00 00         vmovdqa %ymm0,0x0       [a-f0-9]+: R_386_32     ymm24
 [      ]*[a-f0-9]+:    c5 f0 58 05 00 00 00 00         vaddps 0x0,%xmm1,%xmm0  [a-f0-9]+: R_386_32     xmm8
+[      ]*[a-f0-9]+:    c5 f0 58 05 00 00 00 00         vaddps 0x0,%xmm1,%xmm0  [a-f0-9]+: R_386_32     xmm16
+[      ]*[a-f0-9]+:    c5 f0 58 05 00 00 00 00         vaddps 0x0,%xmm1,%xmm0  [a-f0-9]+: R_386_32     xmm24
 [      ]*[a-f0-9]+:    c5 f4 58 05 00 00 00 00         vaddps 0x0,%ymm1,%ymm0  [a-f0-9]+: R_386_32     ymm8
+[      ]*[a-f0-9]+:    c5 f4 58 05 00 00 00 00         vaddps 0x0,%ymm1,%ymm0  [a-f0-9]+: R_386_32     ymm16
+[      ]*[a-f0-9]+:    c5 f4 58 05 00 00 00 00         vaddps 0x0,%ymm1,%ymm0  [a-f0-9]+: R_386_32     ymm24
 [      ]*[a-f0-9]+:    c5 f9 6f 05 00 00 00 00         vmovdqa 0x0,%xmm0       [a-f0-9]+: R_386_32     zmm0
 [      ]*[a-f0-9]+:    c5 f9 6f 05 00 00 00 00         vmovdqa 0x0,%xmm0       [a-f0-9]+: R_386_32     k0
 [      ]*[a-f0-9]+:    0f 58 05 00 00 00 00    addps  0x0,%xmm0        [a-f0-9]+: R_386_32     xmm8
+[      ]*[a-f0-9]+:    0f 58 05 00 00 00 00    addps  0x0,%xmm0        [a-f0-9]+: R_386_32     xmm16
+[      ]*[a-f0-9]+:    0f 58 05 00 00 00 00    addps  0x0,%xmm0        [a-f0-9]+: R_386_32     xmm24
 [      ]*[a-f0-9]+:    0f 58 05 00 00 00 00    addps  0x0,%xmm0        [a-f0-9]+: R_386_32     ymm0
 [      ]*[a-f0-9]+:    0f 58 05 00 00 00 00    addps  0x0,%xmm0        [a-f0-9]+: R_386_32     ymm8
+[      ]*[a-f0-9]+:    0f 58 05 00 00 00 00    addps  0x0,%xmm0        [a-f0-9]+: R_386_32     ymm16
+[      ]*[a-f0-9]+:    0f 58 05 00 00 00 00    addps  0x0,%xmm0        [a-f0-9]+: R_386_32     ymm24
 [      ]*[a-f0-9]+:    0f 58 05 00 00 00 00    addps  0x0,%xmm0        [a-f0-9]+: R_386_32     zmm0
 [      ]*[a-f0-9]+:    0f 58 05 00 00 00 00    addps  0x0,%xmm0        [a-f0-9]+: R_386_32     k0
 [      ]*[a-f0-9]+:    a1 00 00 00 00          mov    0x0,%eax [a-f0-9]+: R_386_32     xmm0

diff --git a/gas/testsuite/gas/i386/xmmhi32.s b/gas/testsuite/gas/i386/xmmhi32.s
index 3847fc491e07c7a4f672c97b99e8ef5aa1f0d2d8..8e8767ac37d0cb9fd7098ebee7b334eb9b64f58a 100644 (file)
--- a/gas/testsuite/gas/i386/xmmhi32.s
+++ b/gas/testsuite/gas/i386/xmmhi32.s
@@ -3,26 +3,46 @@
        .code32
 xmm:
        vaddps  xmm0, xmm1, xmm8
+       vaddps  xmm0, xmm1, xmm16
+       vaddps  xmm0, xmm1, xmm24
        vaddps  ymm0, ymm1, ymm8
+       vaddps  ymm0, ymm1, ymm16
+       vaddps  ymm0, ymm1, ymm24
        vaddps  zmm0, zmm1, zmm8
        vaddps  zmm0, zmm1, zmm16
        vaddps  zmm0, zmm1, zmm24
 
        vmovdqa xmm0, xmm8
+       vmovdqa xmm0, xmm16
+       vmovdqa xmm0, xmm24
        vmovdqa ymm0, ymm8
+       vmovdqa ymm0, ymm16
+       vmovdqa ymm0, ymm24
        vmovdqa xmm8, xmm0
+       vmovdqa xmm16, xmm0
+       vmovdqa xmm24, xmm0
        vmovdqa ymm8, ymm0
+       vmovdqa ymm16, ymm0
+       vmovdqa ymm24, ymm0
 
        .arch .noavx512f
        vaddps  xmm0, xmm1, xmm8
+       vaddps  xmm0, xmm1, xmm16
+       vaddps  xmm0, xmm1, xmm24
        vaddps  ymm0, ymm1, ymm8
+       vaddps  ymm0, ymm1, ymm16
+       vaddps  ymm0, ymm1, ymm24
        vmovdqa xmm0, zmm0
        vmovdqa xmm0, k0
 
        .arch .noavx
        addps   xmm0, xmm8
+       addps   xmm0, xmm16
+       addps   xmm0, xmm24
        addps   xmm0, ymm0
        addps   xmm0, ymm8
+       addps   xmm0, ymm16
+       addps   xmm0, ymm24
        addps   xmm0, zmm0
        addps   xmm0, k0
 

diff --git a/gas/testsuite/gas/i386/xmmhi64.d b/gas/testsuite/gas/i386/xmmhi64.d
new file mode 100644 (file)
index 0000000..f684378
--- /dev/null
+++ b/gas/testsuite/gas/i386/xmmhi64.d
@@ -0,0 +1,12 @@
+#objdump: -dwr
+#name: high XMM registers in 64-bit mode
+
+.*: +file format .*
+
+Disassembly of section .text:
+
+0+ <xmm>:
+[      ]*[a-f0-9]+:    62 b1 74 08 58 c0[      ]+vaddps %xmm16,%xmm1,%xmm0
+[      ]*[a-f0-9]+:    62 b1 74 28 58 c0[      ]+vaddps %ymm16,%ymm1,%ymm0
+[      ]*[a-f0-9]+:    62 b1 74 48 58 c0[      ]+vaddps %zmm16,%zmm1,%zmm0
+#pass

diff --git a/gas/testsuite/gas/i386/xmmhi64.s b/gas/testsuite/gas/i386/xmmhi64.s
new file mode 100644 (file)
index 0000000..4a70cf7
--- /dev/null
+++ b/gas/testsuite/gas/i386/xmmhi64.s
@@ -0,0 +1,7 @@
+       .text
+       .intel_syntax noprefix
+       .code64
+xmm:
+       {vex2} vaddps   xmm0, xmm1, xmm16
+       {vex2} vaddps   ymm0, ymm1, ymm16
+       {vex2} vaddps   zmm0, zmm1, zmm16