draw: reset the vertex id when injecting new primitive id
authorZack Rusin <zackr@vmware.com>
Wed, 7 Aug 2013 00:25:53 +0000 (20:25 -0400)
committerZack Rusin <zackr@vmware.com>
Fri, 9 Aug 2013 00:54:03 +0000 (20:54 -0400)
Without reseting the vertex id, with primitives where the same
vertex is used with different primitives (e.g. tri/lines strips)
our vbuf module won't re-emit those vertices with the changed
primitive id. So lets reset the vertex id whenever injecting
new primitive id to make sure that the vertex data is correctly
emitted.

Signed-off-by: Zack Rusin <zackr@vmware.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
src/gallium/auxiliary/draw/draw_pipe_ia.c

index ecbb23397dcc3969a4155de9d3a87643797dc677..d64f19b38cbbfa86a72d1cf3fa51a41cbc569296 100644 (file)
@@ -68,6 +68,15 @@ inject_primid(struct draw_stage *stage,
 
    for (i = 0; i < num_verts; ++i) {
       struct vertex_header *v = header->v[i];
+      /* We have to reset the vertex_id because it's used by
+       * vbuf to figure out if the vertex had already been
+       * emitted. For line/tri strips the first vertex of
+       * subsequent primitives would already be emitted,
+       * but since we're changing the primitive id on the vertex
+       * we want to make sure it's reemitted with the correct
+       * data.
+       */
+      v->vertex_id = UNDEFINED_VERTEX_ID;
       memcpy(&v->data[slot][0], &primid, sizeof(primid));
       memcpy(&v->data[slot][1], &primid, sizeof(primid));
       memcpy(&v->data[slot][2], &primid, sizeof(primid));