Fix `TheorySetsPrive::eqNotifyPostMerge()` (#3901)
authorAndres Noetzli <andres.noetzli@gmail.com>
Tue, 3 Mar 2020 04:55:22 +0000 (20:55 -0800)
committerGitHub <noreply@github.com>
Tue, 3 Mar 2020 04:55:22 +0000 (22:55 -0600)
A local declaration of `s1` was shadowing `s1`, which meant that the
non-local definition of `s1` could never be not null. This meant that
parts of the code were never run. This commit fixes the issue by
removing the local declaration.

src/theory/sets/theory_sets_private.cpp

index df6f76cbf7a20efdf232a57cf7abafc21bbec96b..1a798414e002f74debc0ac8d47b59ee685cabfa6 100644 (file)
@@ -97,7 +97,6 @@ void TheorySetsPrivate::eqNotifyPostMerge(TNode t1, TNode t2)
     {
       s2 = e2->d_singleton;
       EqcInfo* e1 = getOrMakeEqcInfo(t1);
-      Node s1;
       Trace("sets-prop-debug") << "Merging singletons..." << std::endl;
       if (e1)
       {