* config/tc-s390.c (s390_insn): Correct range check for opcode in

	.insn pseudo operation.

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 106463565047e615bac901f29f899e8dd54af6e2..b8b3d5e58bd4515f2de21b54cb6fb85e8bd06c9e 100644 (file)
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,8 @@
+2004-02-27  Hannes Reinecke  <hare@suse.de>
+
+       * config/tc-s390.c (s390_insn): Correct range check for opcode in
+       .insn pseudo operation.
+
 2004-02-27  Anil Paranjpe  <anilp1@kpitcummins.com>
 
        * config/tc-sh.c (get_operand):  In case of #Imm, check has been

diff --git a/gas/config/tc-s390.c b/gas/config/tc-s390.c
index ef51bca4e560b76ff4a729bb6c4d5babd0ef32dc..c450eaeea75a236fe85341a0c3246aa45c9c4c04 100644 (file)
--- a/gas/config/tc-s390.c
+++ b/gas/config/tc-s390.c
@@ -1614,9 +1614,15 @@ s390_insn (ignore)
   expression (&exp);
   if (exp.X_op == O_constant)
     {
-      if (   (opformat->oplen == 6 && exp.X_op > 0 && exp.X_op < (1ULL << 48))
-         || (opformat->oplen == 4 && exp.X_op > 0 && exp.X_op < (1ULL << 32))
-         || (opformat->oplen == 2 && exp.X_op > 0 && exp.X_op < (1ULL << 16)))
+      if (   (   opformat->oplen == 6
+             && exp.X_add_number >= 0
+             && (addressT) exp.X_add_number < (1ULL << 48))
+         || (   opformat->oplen == 4
+             && exp.X_add_number >= 0
+             && (addressT) exp.X_add_number < (1ULL << 32))
+         || (   opformat->oplen == 2
+             && exp.X_add_number >= 0
+             && (addressT) exp.X_add_number < (1ULL << 16)))
        md_number_to_chars (insn, exp.X_add_number, opformat->oplen);
       else
        as_bad (_("Invalid .insn format\n"));