Wed Mar 4 16:53:52 1998 Martin M. Hunt <hunt@cygnus.com>

	* serial.c (_initialize_serial): Add a description of
	"set remotelogbase".

	* command.c (do_setshow_command): If no arguments are supplied,
	don't dump core, instead print out an error message.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 3209545c3a9222b638b18f7f6deea6303162a9ab..6bb149d81653d29515d71a36d4ba28193931412c 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,11 @@
+Wed Mar  4 16:53:52 1998  Martin M. Hunt  <hunt@cygnus.com>
+
+       * serial.c (_initialize_serial): Add a description of 
+       "set remotelogbase".
+
+       * command.c (do_setshow_command): If no arguments are supplied,
+       don't dump core, instead print out an error message.
+
 Wed Mar  4 16:50:18 1998  Jason Molenda  (crash@bugshack.cygnus.com)
 
        * gdbtk.c (gdb_listfiles): Fix thinko in last change.

diff --git a/gdb/command.c b/gdb/command.c
index bd5c1231db0414535c4785779fc4c8c5eb392a90..8109b937540990545e0f9c46207cea58ecedee7e 100644 (file)
--- a/gdb/command.c
+++ b/gdb/command.c
@@ -281,7 +281,6 @@ add_set_enum_cmd (name, class, enumlist, var, doc, list)
 {
   struct cmd_list_element *c
     = add_set_cmd (name, class, var_enum, var, doc, list);
-
   c->enums = enumlist;
 
   return c;
@@ -1269,8 +1268,23 @@ do_setshow_command (arg, from_tty, c)
            char *match = NULL;
            char *p;
 
-           p = strchr (arg, ' ');
+           /* if no argument was supplied, print an informative error message */
+           if (arg == NULL)
+             {
+               char msg[1024];
+               strcpy (msg, "Requires an argument. Valid arguments are ");
+               for (i = 0; c->enums[i]; i++)
+                 {
+                   if (i != 0)
+                     strcat (msg, ", ");
+                   strcat (msg, c->enums[i]);
+                 }
+               strcat (msg, ".");
+               error (msg);
+             }
 
+           p = strchr (arg, ' ');
+           
            if (p)
              len = p - arg;
            else

diff --git a/gdb/serial.c b/gdb/serial.c
index 4bbc22dc43ab25889eb10dc2bd63cc9ca74766a0..89a116e565c8223006e986f264488601206bcbb0 100644 (file)
--- a/gdb/serial.c
+++ b/gdb/serial.c
@@ -517,7 +517,7 @@ by gdbserver.", &setlist),
   add_show_from_set (add_set_enum_cmd ("remotelogbase", no_class,
                                       logbase_enums,
                                       (char *)&serial_logbase,
-                                      "Set ...",
+                                      "Set numerical base for remote session logging",
                                       &setlist),
                           &showlist);
 }