Split out eval_op_gtr

This splits BINOP_GTR into a new function for future use.

gdb/ChangeLog
2021-03-08  Tom Tromey  <tom@tromey.com>

	* eval.c (eval_op_gtr): New function.
	(evaluate_subexp_standard): Use it.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d250cf539ededed719ec622e9731968c85fa5e6d..580c0f7647e7cd5b46310cf6820ae408095a633c 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2021-03-08  Tom Tromey  <tom@tromey.com>
+
+       * eval.c (eval_op_gtr): New function.
+       (evaluate_subexp_standard): Use it.
+
 2021-03-08  Tom Tromey  <tom@tromey.com>
 
        * eval.c (eval_op_less): New function.

diff --git a/gdb/eval.c b/gdb/eval.c
index 8e8846d2337caad4a61329d46f5de74436154022..628ae662654cb485080345b085fe082f569f9566 100644 (file)
--- a/gdb/eval.c
+++ b/gdb/eval.c
@@ -1660,6 +1660,29 @@ eval_op_less (struct type *expect_type, struct expression *exp,
     }
 }
 
+/* A helper function for BINOP_GTR.  */
+
+static struct value *
+eval_op_gtr (struct type *expect_type, struct expression *exp,
+            enum noside noside, enum exp_opcode op,
+            struct value *arg1, struct value *arg2)
+{
+  if (noside == EVAL_SKIP)
+    return eval_skip_value (exp);
+  if (binop_user_defined_p (op, arg1, arg2))
+    {
+      return value_x_binop (arg1, arg2, op, OP_NULL, noside);
+    }
+  else
+    {
+      binop_promote (exp->language_defn, exp->gdbarch, &arg1, &arg2);
+      int tem = value_less (arg2, arg1);
+      struct type *type = language_bool_type (exp->language_defn,
+                                             exp->gdbarch);
+      return value_from_longest (type, (LONGEST) tem);
+    }
+}
+
 struct value *
 evaluate_subexp_standard (struct type *expect_type,
                          struct expression *exp, int *pos,
@@ -2486,19 +2509,7 @@ evaluate_subexp_standard (struct type *expect_type,
     case BINOP_GTR:
       arg1 = evaluate_subexp (nullptr, exp, pos, noside);
       arg2 = evaluate_subexp (value_type (arg1), exp, pos, noside);
-      if (noside == EVAL_SKIP)
-       return eval_skip_value (exp);
-      if (binop_user_defined_p (op, arg1, arg2))
-       {
-         return value_x_binop (arg1, arg2, op, OP_NULL, noside);
-       }
-      else
-       {
-         binop_promote (exp->language_defn, exp->gdbarch, &arg1, &arg2);
-         tem = value_less (arg2, arg1);
-         type = language_bool_type (exp->language_defn, exp->gdbarch);
-         return value_from_longest (type, (LONGEST) tem);
-       }
+      return eval_op_gtr (expect_type, exp, noside, op, arg1, arg2);
 
     case BINOP_GEQ:
       arg1 = evaluate_subexp (nullptr, exp, pos, noside);