libiberty: dupargv: rewrite to use xstrdup

This func is basically open coding the xstrdup function, so gut it
and use it directly.

diff --git a/libiberty/ChangeLog b/libiberty/ChangeLog
index aa598f277b2bd39943d887f8117ad6714601b3e6..ba1e0a51c337f004ae8ce2df9781eb15ae1170c1 100644 (file)
--- a/libiberty/ChangeLog
+++ b/libiberty/ChangeLog
@@ -1,3 +1,7 @@
+2016-01-05  Mike Frysinger  <vapier@gentoo.org>
+
+       * argv.c (dupargv): Replace strlen/xmalloc/strcpy with xstrdup.
+
 2015-12-28  Patrick Palka  <ppalka@gcc.gnu.org>
 
        * crc32.c: In the documentation, don't refer to GDB's

diff --git a/libiberty/argv.c b/libiberty/argv.c
index f2727e8de95db2d849f57e690e64a9dbc08853ff..5c3dd70b0422c77076944d0266c5817c96b284a3 100644 (file)
--- a/libiberty/argv.c
+++ b/libiberty/argv.c
@@ -76,11 +76,7 @@ dupargv (char **argv)
 
   /* the strings */
   for (argc = 0; argv[argc] != NULL; argc++)
-    {
-      int len = strlen (argv[argc]);
-      copy[argc] = (char *) xmalloc (len + 1);
-      strcpy (copy[argc], argv[argc]);
-    }
+    copy[argc] = xstrdup (argv[argc]);
   copy[argc] = NULL;
   return copy;
 }