expand_symtab_containing_pc: Renamed from find_pc_sect_symtab_via_partial.

This patch just renames one function.
Its only caller is in stack.c where we're printing a backtrace
with non-zero info_verbose and we want to make sure all the needed
symtabs are expanded before printing the backtrace
so that debug symbol reading messages don't pollute the backtrace.

I think the new name of the function makes clearer to the reader
what is going on.

gdb/ChangeLog:

	* symtab.c (expand_symtab_containing_pc): Renamed from
	find_pc_sect_symtab_via_partial.  All callers updated.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 3b9ba33032d506b02a1769edddb479510dee10e3..6198d5433c4d02789a56c9bfe58bed2fbb4a8062 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2014-11-15  Doug Evans  <xdje42@gmail.com>
+
+       * symtab.c (expand_symtab_containing_pc): Renamed from
+       find_pc_sect_symtab_via_partial.  All callers updated.
+
 2014-11-15  Yao Qi  <yao@codesourcery.com>
 
        * go32-nat.c (go32_create_inferior): Add missing parenthesis.

diff --git a/gdb/stack.c b/gdb/stack.c
index 4b34e0b8c594a391c1361eae42671a6c9bc211ce..35f491dfb345a13bb525cf148ec2aa42f07cf52e 100644 (file)
--- a/gdb/stack.c
+++ b/gdb/stack.c
@@ -1776,7 +1776,7 @@ backtrace_command_1 (char *count_exp, int show_locals, int no_filters,
 
          QUIT;
          pc = get_frame_address_in_block (fi);
-         find_pc_sect_symtab_via_partial (pc, find_pc_mapped_section (pc));
+         expand_symtab_containing_pc (pc, find_pc_mapped_section (pc));
        }
     }
 

diff --git a/gdb/symtab.c b/gdb/symtab.c
index 4f4ecf81e87ec7631f4f360cf7f176f4c3ea1fe7..4672ac31eabf2b53fddc6ccd3d3d19be699cdecd 100644 (file)
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -1045,8 +1045,10 @@ matching_obj_sections (struct obj_section *obj_first,
   return 0;
 }
 
-struct symtab *
-find_pc_sect_symtab_via_partial (CORE_ADDR pc, struct obj_section *section)
+/* See symtab.h.  */
+
+void
+expand_symtab_containing_pc (CORE_ADDR pc, struct obj_section *section)
 {
   struct objfile *objfile;
   struct bound_minimal_symbol msymbol;
@@ -1061,20 +1063,18 @@ find_pc_sect_symtab_via_partial (CORE_ADDR pc, struct obj_section *section)
          || MSYMBOL_TYPE (msymbol.minsym) == mst_abs
          || MSYMBOL_TYPE (msymbol.minsym) == mst_file_data
          || MSYMBOL_TYPE (msymbol.minsym) == mst_file_bss))
-    return NULL;
+    return;
 
   ALL_OBJFILES (objfile)
   {
-    struct symtab *result = NULL;
+    struct symtab *s = NULL;
 
     if (objfile->sf)
-      result = objfile->sf->qf->find_pc_sect_symtab (objfile, msymbol,
-                                                    pc, section, 0);
-    if (result)
-      return result;
+      s = objfile->sf->qf->find_pc_sect_symtab (objfile, msymbol,
+                                               pc, section, 0);
+    if (s != NULL)
+      return;
   }
-
-  return NULL;
 }
 \f
 /* Debug symbols usually don't have section information.  We need to dig that

diff --git a/gdb/symtab.h b/gdb/symtab.h
index d78b832cf9d6be33123239ad3f3ec68b5cdfbc49..d69fbcfc32000e180c939ee6b8fe251b4cc02322 100644 (file)
--- a/gdb/symtab.h
+++ b/gdb/symtab.h
@@ -1163,10 +1163,9 @@ extern int find_pc_partial_function (CORE_ADDR, const char **, CORE_ADDR *,
 
 extern void clear_pc_function_cache (void);
 
-/* lookup partial symbol table by address and section.  */
+/* Expand symtab containing PC, SECTION if not already expanded.  */
 
-extern struct symtab *find_pc_sect_symtab_via_partial (CORE_ADDR,
-                                                      struct obj_section *);
+extern void expand_symtab_containing_pc (CORE_ADDR, struct obj_section *);
 
 /* lookup full symbol table by address.  */