Use __builtin_memmove for trivially copyable types
authorGlen Joseph Fernandes <glenjofe@gmail.com>
Thu, 19 Jul 2018 18:58:09 +0000 (18:58 +0000)
committerJonathan Wakely <redi@gcc.gnu.org>
Thu, 19 Jul 2018 18:58:09 +0000 (19:58 +0100)
2018-07-19  Glen Joseph Fernandes  <glenjofe@gmail.com>

* include/bits/stl_algobase.h (__copy_move_a): Used
__is_trivially_copyable.
(__copy_move_backward_a): Likewise.
* testsuite/20_util/specialized_algorithms/uninitialized_copy/1.cc:
New test.

From-SVN: r262884

libstdc++-v3/ChangeLog
libstdc++-v3/include/bits/stl_algobase.h
libstdc++-v3/testsuite/20_util/specialized_algorithms/uninitialized_copy/1.cc [new file with mode: 0644]

index 4345d299deda986689a2d9a097d0bbe4239fb07f..00bcf2de3c1b689820a3f35d7e90a5ef5e81cd15 100644 (file)
@@ -1,3 +1,11 @@
+2018-07-19  Glen Joseph Fernandes  <glenjofe@gmail.com>
+
+       * include/bits/stl_algobase.h (__copy_move_a): Used
+       __is_trivially_copyable.
+       (__copy_move_backward_a): Likewise.
+       * testsuite/20_util/specialized_algorithms/uninitialized_copy/1.cc:
+       New test.
+
 2018-07-17  Jonathan Wakely  <jwakely@redhat.com>
 
        PR libstdc++/86450
index 16a3f83b610b71f6feeaf96469205d1d71819fd9..f0130bc412361eb3526631e42774e73e0f63530b 100644 (file)
@@ -391,7 +391,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
       typedef typename iterator_traits<_II>::value_type _ValueTypeI;
       typedef typename iterator_traits<_OI>::value_type _ValueTypeO;
       typedef typename iterator_traits<_II>::iterator_category _Category;
-      const bool __simple = (__is_trivial(_ValueTypeI)
+      const bool __simple = (__is_trivially_copyable(_ValueTypeI)
                             && __is_pointer<_II>::__value
                             && __is_pointer<_OI>::__value
                             && __are_same<_ValueTypeI, _ValueTypeO>::__value);
@@ -593,7 +593,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
       typedef typename iterator_traits<_BI1>::value_type _ValueType1;
       typedef typename iterator_traits<_BI2>::value_type _ValueType2;
       typedef typename iterator_traits<_BI1>::iterator_category _Category;
-      const bool __simple = (__is_trivial(_ValueType1)
+      const bool __simple = (__is_trivially_copyable(_ValueType1)
                             && __is_pointer<_BI1>::__value
                             && __is_pointer<_BI2>::__value
                             && __are_same<_ValueType1, _ValueType2>::__value);
diff --git a/libstdc++-v3/testsuite/20_util/specialized_algorithms/uninitialized_copy/1.cc b/libstdc++-v3/testsuite/20_util/specialized_algorithms/uninitialized_copy/1.cc
new file mode 100644 (file)
index 0000000..461d1f2
--- /dev/null
@@ -0,0 +1,37 @@
+// Copyright (C) 2018 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+// { dg-do compile { target c++11 } }
+
+#include <memory>
+
+struct T
+{
+  T() { }
+  T(const T&) = delete;
+};
+
+static_assert(__is_trivially_assignable(T&, const T&) &&
+  !__is_trivial(T), "T is only trivially copy assignable");
+
+void
+test01(T* result)
+{
+  T t[1];
+  std::uninitialized_copy(t, t+1, result); // { dg-error "here" }
+}
+// { dg-prune-output "use of deleted function" }