aco: fix gfx10_wave64_bpermute
authorRhys Perry <pendingchaos02@gmail.com>
Mon, 3 Feb 2020 17:54:07 +0000 (17:54 +0000)
committerMarge Bot <eric+marge@anholt.net>
Thu, 6 Feb 2020 16:43:03 +0000 (16:43 +0000)
Since 9254fb4fc72, the pass replaced the SCC clobber with the scalar
identity temporary. Just skip most of the temporary setup, since we don't
need it for gfx10_wave64_bpermute.

Although shuffles are disabled on GFX10, Detroit: Become Human seems to
use them anyway.

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-By: Timur Kristóf <timur.kristof@gmail.com>
Fixes: 9254fb4fc72ed289ffded28ef067b4582973e90c ('aco: don't use a scalar
       temporary for reductions on GFX10')

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3683>

src/amd/compiler/aco_reduce_assign.cpp

index 58c64cfb0194ef2471c70e9ded4b043aba0bdfb4..96846e926d426e94f8d61ad376f384c27abc20f0 100644 (file)
@@ -114,6 +114,11 @@ void setup_reduce_temp(Program* program)
             }
          }
 
+         if (op == gfx10_wave64_bpermute) {
+            instr->operands[1] = Operand(reduceTmp);
+            continue;
+         }
+
          /* same as before, except for the vector temporary instead of the reduce temporary */
          unsigned cluster_size = static_cast<Pseudo_reduction_instruction *>(instr)->cluster_size;
          bool need_vtmp = op == imul32 || op == fadd64 || op == fmul64 ||
@@ -121,7 +126,7 @@ void setup_reduce_temp(Program* program)
                           op == umax64 || op == imin64 || op == imax64 ||
                           op == imul64;
 
-         if (program->chip_class >= GFX10 && cluster_size == 64 && op != gfx10_wave64_bpermute)
+         if (program->chip_class >= GFX10 && cluster_size == 64)
             need_vtmp = true;
          if (program->chip_class >= GFX10 && op == iadd64)
             need_vtmp = true;