2002-04-12 Don Howard <dhoward@redhat.com>

	* cli/cli-cmds.c (init_cli_cmds): Add new user settable value:
	max_user_call_depth.
	(init_cmd_lists): Initialize the new value;
	* cli/cli-script.c (execute_user_command): Limit the call depth of
	user defined commands.  This avoids a core-dump when user commands
	are infinitly recursive.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index aa4b1dbb12c46356310e126a2698aa314741dcb8..bca2712cd3435a29ecffc73e3b417eacdec05f3e 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,12 @@
+2002-04-12  Don Howard  <dhoward@redhat.com>
+
+       * cli/cli-cmds.c (init_cli_cmds): Add new user settable value:
+       max_user_call_depth.
+       (init_cmd_lists): Initialize the new value;
+       * cli/cli-script.c (execute_user_command): Limit the call depth of
+       user defined commands.  This avoids a core-dump when user commands
+       are infinitly recursive.
+
 2002-04-12  Kevin Buettner  <kevinb@redhat.com>
 
        * ppc-tdep.h (struct gdbarch_tdep): Add new member ``lr_frame_offset''.

diff --git a/gdb/NEWS b/gdb/NEWS
index 23777175fef90e842cb5ad742d4e8a72f46fbe12..65621ff6fa4d299f4c015dc4903f0a97a21b10ed 100644 (file)
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -3,6 +3,11 @@
 
 *** Changes since GDB 5.2:
 
+* New command "set max-user-call-depth <nnn>"
+
+This command allows the user to limit the call depth of user-defined
+commands.  The default is 1024.
+
 * Changes in FreeBSD/i386 native debugging.
 
 Support for the "generate-core-file" has been added.

diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c
index 6ba686fce42971971f368d9c2fbb7f96f41eeb99..bcd9a42e1b5c4cdfb3cb9672844dac776215bcfa 100644 (file)
--- a/gdb/cli/cli-cmds.c
+++ b/gdb/cli/cli-cmds.c
@@ -80,6 +80,9 @@ static void shell_escape (char *, int);
 
 void apropos_command (char *, int);
 \f
+/* Limit the call depth of user-defined commands */
+int max_user_call_depth;
+
 /* Define all cmd_list_elements.  */
 
 /* Chain containing all defined commands.  */
@@ -606,6 +609,8 @@ show_debug (char *args, int from_tty)
 void
 init_cmd_lists (void)
 {
+  max_user_call_depth = 1024;
+
   cmdlist = NULL;
   infolist = NULL;
   enablelist = NULL;
@@ -823,4 +828,11 @@ With no arguments, run an inferior shell.");
 Argument is the name of the user defined command.\n\
 With no argument, show definitions of all user defined commands.", &showlist);
   add_com ("apropos", class_support, apropos_command, "Search for commands matching a REGEXP");
+
+  add_show_from_set (
+                     add_set_cmd ("max-user-call-depth", no_class, var_integer, 
+                                  (char *) &max_user_call_depth,
+                                  "Set the max call depth for user-defined commands.\n", 
+                                  &setlist),
+                     &showlist);
 }

diff --git a/gdb/cli/cli-script.c b/gdb/cli/cli-script.c
index b438fef02df1560cc83c40acb4c9bd5396e0da33..fc3261c7adedc93aba30e5772677592a10f96147 100644 (file)
--- a/gdb/cli/cli-script.c
+++ b/gdb/cli/cli-script.c
@@ -247,6 +247,15 @@ execute_cmd_post_hook (struct cmd_list_element *c)
 }
 
 /* Execute the command in CMD.  */
+void
+do_restore_user_call_depth (void * call_depth)
+{      
+  int * depth = call_depth;
+  /* We will be returning_to_top_level() at this point, so we want to
+     reset our depth. */
+  (*depth) = 0;
+}
+
 
 void
 execute_user_command (struct cmd_list_element *c, char *args)
@@ -254,6 +263,8 @@ execute_user_command (struct cmd_list_element *c, char *args)
   register struct command_line *cmdlines;
   struct cleanup *old_chain;
   enum command_control_type ret;
+  static int user_call_depth = 0;
+  extern int max_user_call_depth;
 
   old_chain = setup_user_args (args);
 
@@ -262,6 +273,11 @@ execute_user_command (struct cmd_list_element *c, char *args)
     /* Null command */
     return;
 
+  if (++user_call_depth > max_user_call_depth)
+    error ("Max user call depth exceeded -- command aborted\n");
+
+  old_chain = make_cleanup (do_restore_user_call_depth, &user_call_depth);
+
   /* Set the instream to 0, indicating execution of a
      user-defined function.  */
   old_chain = make_cleanup (do_restore_instream_cleanup, instream);
@@ -277,6 +293,8 @@ execute_user_command (struct cmd_list_element *c, char *args)
       cmdlines = cmdlines->next;
     }
   do_cleanups (old_chain);
+
+  user_call_depth--;
 }
 
 enum command_control_type

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 028ee34e19d4e77091c6de3b390b6b6d2fad9226..12e49935110fb56fc70e230dbf8093eb9b2d2321 100644 (file)
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -12781,6 +12781,13 @@ Display the @value{GDBN} commands used to define @var{commandname} (but
 not its documentation).  If no @var{commandname} is given, display the
 definitions for all user-defined commands.
 
+@kindex show max-user-call-depth
+@kindex set max-user-call-depth
+@item show max-user-call-depth
+@item set max-user-call-depth
+The value of @code{max-user-call-depth} controls how many levels deep a
+user-defined call chain can go.  Default is 1024.
+
 @end table
 
 When user-defined commands are executed, the