iris: Fix 4GB memory zone heap sizes.
authorKenneth Graunke <kenneth@whitecape.org>
Sat, 27 Apr 2019 00:12:24 +0000 (17:12 -0700)
committerKenneth Graunke <kenneth@whitecape.org>
Sat, 4 May 2019 02:48:37 +0000 (19:48 -0700)
The STATE_BASE_ADDRESS "Size" fields can only hold 0xfffff in pages,
and 0xfffff * 4096 = 4294963200, which is 1 page shy of 4GB.

So we can't use the top page.

src/gallium/drivers/iris/iris_bufmgr.c

index 6f53f214caa90164af6285b71ecb6edc0e898c6b..c38b960c5dd6cc3146c5899cb8e3d43108330a27 100644 (file)
@@ -1670,14 +1670,17 @@ iris_bufmgr_init(struct gen_device_info *devinfo, int fd)
    STATIC_ASSERT(IRIS_MEMZONE_SHADER_START == 0ull);
    const uint64_t _4GB = 1ull << 32;
 
+   /* The STATE_BASE_ADDRESS size field can only hold 1 page shy of 4GB */
+   const uint64_t _4GB_minus_1 = _4GB - PAGE_SIZE;
+
    util_vma_heap_init(&bufmgr->vma_allocator[IRIS_MEMZONE_SHADER],
-                      PAGE_SIZE, _4GB - PAGE_SIZE);
+                      PAGE_SIZE, _4GB_minus_1 - PAGE_SIZE);
    util_vma_heap_init(&bufmgr->vma_allocator[IRIS_MEMZONE_SURFACE],
                       IRIS_MEMZONE_SURFACE_START,
-                      _4GB - IRIS_MAX_BINDERS * IRIS_BINDER_SIZE);
+                      _4GB_minus_1 - IRIS_MAX_BINDERS * IRIS_BINDER_SIZE);
    util_vma_heap_init(&bufmgr->vma_allocator[IRIS_MEMZONE_DYNAMIC],
                       IRIS_MEMZONE_DYNAMIC_START + IRIS_BORDER_COLOR_POOL_SIZE,
-                      _4GB - IRIS_BORDER_COLOR_POOL_SIZE);
+                      _4GB_minus_1 - IRIS_BORDER_COLOR_POOL_SIZE);
    util_vma_heap_init(&bufmgr->vma_allocator[IRIS_MEMZONE_OTHER],
                       IRIS_MEMZONE_OTHER_START,
                       gtt_size - IRIS_MEMZONE_OTHER_START);