PR c/97955 - ICE in build_array_type_1 on invalid redeclaration of function with...
authorMartin Sebor <msebor@redhat.com>
Tue, 24 Nov 2020 22:23:57 +0000 (15:23 -0700)
committerMartin Sebor <msebor@redhat.com>
Tue, 24 Nov 2020 22:23:57 +0000 (15:23 -0700)
gcc/c-family/ChangeLog:

* c-warn.c (warn_parm_array_mismatch): Avoid invalid redeclarations.

gcc/testsuite/ChangeLog:

* gcc.dg/pr97955.c: New test.

gcc/c-family/c-warn.c
gcc/testsuite/gcc.dg/pr97955.c [new file with mode: 0644]

index 6d22a113ad0acc3b10258be14ec9355e3b6473e8..91abafe49b1a57db803b75a81a248be206093d1d 100644 (file)
@@ -3379,8 +3379,9 @@ warn_parm_array_mismatch (location_t origloc, tree fndecl, tree newparms)
        return;
 
       /* Only check pointers and C++ references.  */
+      tree curptype = TREE_TYPE (curp);
       tree newptype = TREE_TYPE (newp);
-      if (!POINTER_TYPE_P (newptype))
+      if (!POINTER_TYPE_P (curptype) || !POINTER_TYPE_P (newptype))
        continue;
 
       /* Skip mismatches in __builtin_va_list that is commonly
@@ -3430,7 +3431,6 @@ warn_parm_array_mismatch (location_t origloc, tree fndecl, tree newparms)
       if (origloc == UNKNOWN_LOCATION)
        origloc = newloc;
 
-      tree curptype = TREE_TYPE (curp);
       const std::string newparmstr = newa->array_as_string (newptype);
       const std::string curparmstr = cura->array_as_string (curptype);
       if (new_vla_p && !cur_vla_p)
diff --git a/gcc/testsuite/gcc.dg/pr97955.c b/gcc/testsuite/gcc.dg/pr97955.c
new file mode 100644 (file)
index 0000000..a5236c7
--- /dev/null
@@ -0,0 +1,7 @@
+/* PR 97955 - ICE in build_array_type_1 on invalid redeclaration of function
+   with VLA parameter
+   { dg-do compile }
+   { dg-options "-Wall" } */
+
+void f (int n, int a[n]);
+void f (int *b) { }           // { dg-error "conflicting types" }