r300g: Expound on dithering comment.
authorCorbin Simpson <MostAwesomeDude@gmail.com>
Fri, 2 Apr 2010 21:21:50 +0000 (14:21 -0700)
committerCorbin Simpson <MostAwesomeDude@gmail.com>
Fri, 2 Apr 2010 21:21:50 +0000 (14:21 -0700)
src/gallium/drivers/r300/r300_state.c

index bf17d5d92036768eb45f39234c54dfc87db12130..2c0a7d82f5b3bf4435308f8b1c011dc33e9d2b54 100644 (file)
@@ -320,12 +320,17 @@ static void* r300_create_blend_state(struct pipe_context* pipe,
         }
     }
 
+    /* Neither fglrx nor classic r300 ever set this, regardless of dithering
+     * state. Since it's an optional implementation detail, we can leave it
+     * out and never dither.
+     *
+     * This could be revisited if we ever get quality or conformance hints.
+     *
     if (state->dither) {
-       /* fglrx appears to never set this */
-       blend->dither = 0;
-        /* blend->dither = R300_RB3D_DITHER_CTL_DITHER_MODE_LUT |
-                           R300_RB3D_DITHER_CTL_ALPHA_DITHER_MODE_LUT; */
+        blend->dither = R300_RB3D_DITHER_CTL_DITHER_MODE_LUT |
+                        R300_RB3D_DITHER_CTL_ALPHA_DITHER_MODE_LUT;
     }
+    */
 
     return (void*)blend;
 }