COFF: Check for symbols defined in discarded section

For LTO, a symbol may defined in discarded section.  We should mark it
as undefined so that LTO plugin will make IR definition available.

	PR ld/24267
	* coffgen.c (_bfd_coff_section_already_linked): Skip discarded
	section.
	* cofflink.c (coff_link_add_symbols): Check for symbols defined
	in discarded section.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index b044fad208f903236353aea4df84b11fb404f5b0..b019ca6fa43c4d43e38b18e1d6c8fc96e5baa71f 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,11 @@
+2019-03-15  H.J. Lu  <hongjiu.lu@intel.com>
+
+       PR ld/24267
+       * coffgen.c (_bfd_coff_section_already_linked): Skip discarded
+       section.
+       * cofflink.c (coff_link_add_symbols): Check for symbols defined
+       in discarded section.
+
 2019-03-15  Alan Modra  <amodra@gmail.com>
 
        PR 24339

diff --git a/bfd/coffgen.c b/bfd/coffgen.c
index 5db35c7ddf13bdfa9b05883e0aa783c2e53a1e92..ccf4b4302c5dd81f0e732e718dc3ce0b1d18fac9 100644 (file)
--- a/bfd/coffgen.c
+++ b/bfd/coffgen.c
@@ -2652,6 +2652,9 @@ _bfd_coff_section_already_linked (bfd *abfd,
   struct bfd_section_already_linked_hash_entry *already_linked_list;
   struct coff_comdat_info *s_comdat;
 
+  if (sec->output_section == bfd_abs_section_ptr)
+    return FALSE;
+
   flags = sec->flags;
   if ((flags & SEC_LINK_ONCE) == 0)
     return FALSE;

diff --git a/bfd/cofflink.c b/bfd/cofflink.c
index e4031b9a31ea1daf167b249b7af5859145ba49aa..ac07d05e5789812fec774aa6bf8cbe0941c5dfcf 100644 (file)
--- a/bfd/cofflink.c
+++ b/bfd/cofflink.c
@@ -310,7 +310,9 @@ coff_link_add_symbols (bfd *abfd,
            case COFF_SYMBOL_GLOBAL:
              flags = BSF_EXPORT | BSF_GLOBAL;
              section = coff_section_from_bfd_index (abfd, sym.n_scnum);
-             if (! obj_pe (abfd))
+             if (discarded_section (section))
+               section = bfd_und_section_ptr;
+             else if (! obj_pe (abfd))
                value -= section->vma;
              break;
 
@@ -327,6 +329,8 @@ coff_link_add_symbols (bfd *abfd,
            case COFF_SYMBOL_PE_SECTION:
              flags = BSF_SECTION_SYM | BSF_GLOBAL;
              section = coff_section_from_bfd_index (abfd, sym.n_scnum);
+             if (discarded_section (section))
+               section = bfd_und_section_ptr;
              break;
            }