freedreno/a4xx: remove RB_RENDER_CONTROL patching

Bitfields where shuffled around for the better on a4xx, so we don't need
any patching on this one.  It appears to be something we set entirely in
the gmem code so no conflict between tiling and render state like we had
in a3xx.

Signed-off-by: Rob Clark <robclark@freedesktop.org>

diff --git a/src/gallium/drivers/freedreno/a4xx/fd4_context.c b/src/gallium/drivers/freedreno/a4xx/fd4_context.c
index 7d6365bbb6da52b42b0f556eb0434721ad895bc6..62cfda97ac374e888ff0f319789a838478e79296 100644 (file)
--- a/src/gallium/drivers/freedreno/a4xx/fd4_context.c
+++ b/src/gallium/drivers/freedreno/a4xx/fd4_context.c
@@ -43,8 +43,6 @@ fd4_context_destroy(struct pipe_context *pctx)
 {
        struct fd4_context *fd4_ctx = fd4_context(fd_context(pctx));
 
-       util_dynarray_fini(&fd4_ctx->rbrc_patches);
-
        fd_bo_del(fd4_ctx->vs_pvt_mem);
        fd_bo_del(fd4_ctx->fs_pvt_mem);
        fd_bo_del(fd4_ctx->vsc_size_mem);
@@ -127,8 +125,6 @@ fd4_context_create(struct pipe_screen *pscreen, void *priv, unsigned flags)
        if (!pctx)
                return NULL;
 
-       util_dynarray_init(&fd4_ctx->rbrc_patches);
-
        fd4_ctx->vs_pvt_mem = fd_bo_new(screen->dev, 0x2000,
                        DRM_FREEDRENO_GEM_TYPE_KMEM);
 

diff --git a/src/gallium/drivers/freedreno/a4xx/fd4_context.h b/src/gallium/drivers/freedreno/a4xx/fd4_context.h
index 0c1027d580499050135d33eff5105514dd3701c6..8996de932b8576bef9a15aca3d1cc4fbc99ea7be 100644 (file)
--- a/src/gallium/drivers/freedreno/a4xx/fd4_context.h
+++ b/src/gallium/drivers/freedreno/a4xx/fd4_context.h
@@ -40,11 +40,6 @@
 struct fd4_context {
        struct fd_context base;
 
-       /* Keep track of writes to RB_RENDER_CONTROL which need to be patched
-        * once we know whether or not to use GMEM, and GMEM tile pitch.
-        */
-       struct util_dynarray rbrc_patches;
-
        struct fd_bo *vs_pvt_mem, *fs_pvt_mem;
 
        /* This only needs to be 4 * num_of_pipes bytes (ie. 32 bytes).  We

diff --git a/src/gallium/drivers/freedreno/a4xx/fd4_emit.c b/src/gallium/drivers/freedreno/a4xx/fd4_emit.c
index e887abf709f3dfec1146eea177426a48143d0661..58ddf2aeebe5bd48041cf75331f3a4b3a7828ba5 100644 (file)
--- a/src/gallium/drivers/freedreno/a4xx/fd4_emit.c
+++ b/src/gallium/drivers/freedreno/a4xx/fd4_emit.c
@@ -485,19 +485,6 @@ fd4_emit_state(struct fd_context *ctx, struct fd_ringbuffer *ring,
                                A4XX_RB_RENDER_COMPONENTS_RT7(mrt_comp[7]));
        }
 
-       if ((dirty & (FD_DIRTY_ZSA | FD_DIRTY_PROG)) && !emit->key.binning_pass) {
-               uint32_t val = fd4_zsa_stateobj(ctx->zsa)->rb_render_control;
-
-               /* I suppose if we needed to (which I don't *think* we need
-                * to), we could emit this for binning pass too.  But we
-                * would need to keep a different patch-list for binning
-                * vs render pass.
-                */
-
-               OUT_PKT0(ring, REG_A4XX_RB_RENDER_CONTROL, 1);
-               OUT_RINGP(ring, val, &fd4_context(ctx)->rbrc_patches);
-       }
-
        if (dirty & (FD_DIRTY_ZSA | FD_DIRTY_FRAMEBUFFER)) {
                struct fd4_zsa_stateobj *zsa = fd4_zsa_stateobj(ctx->zsa);
                struct pipe_framebuffer_state *pfb = &ctx->framebuffer;

diff --git a/src/gallium/drivers/freedreno/a4xx/fd4_gmem.c b/src/gallium/drivers/freedreno/a4xx/fd4_gmem.c
index 221608127b42b2213f5ec538ee8f22db1a99bfe0..bb740881037e269726e2123d6c717e7a2bed8ca9 100644 (file)
--- a/src/gallium/drivers/freedreno/a4xx/fd4_gmem.c
+++ b/src/gallium/drivers/freedreno/a4xx/fd4_gmem.c
@@ -502,18 +502,6 @@ patch_draws(struct fd_context *ctx, enum pc_di_vis_cull_mode vismode)
        util_dynarray_resize(&ctx->draw_patches, 0);
 }
 
-static void
-patch_rbrc(struct fd_context *ctx, uint32_t val)
-{
-       struct fd4_context *fd4_ctx = fd4_context(ctx);
-       unsigned i;
-       for (i = 0; i < fd_patch_num_elements(&fd4_ctx->rbrc_patches); i++) {
-               struct fd_cs_patch *patch = fd_patch_element(&fd4_ctx->rbrc_patches, i);
-               *patch->cs = patch->val | val;
-       }
-       util_dynarray_resize(&fd4_ctx->rbrc_patches, 0);
-}
-
 /* for rendering directly to system memory: */
 static void
 fd4_emit_sysmem_prep(struct fd_context *ctx)
@@ -545,8 +533,10 @@ fd4_emit_sysmem_prep(struct fd_context *ctx)
                        A4XX_RB_MODE_CONTROL_HEIGHT(0) |
                        0x00c00000);  /* XXX */
 
+       OUT_PKT0(ring, REG_A4XX_RB_RENDER_CONTROL, 1);
+       OUT_RING(ring, 0x8);
+
        patch_draws(ctx, IGNORE_VISIBILITY);
-       patch_rbrc(ctx, 0);  // XXX
 }
 
 static void
@@ -591,7 +581,6 @@ fd4_emit_tile_init(struct fd_context *ctx)
 {
        struct fd_ringbuffer *ring = ctx->ring;
        struct fd_gmem_stateobj *gmem = &ctx->gmem;
-       uint32_t rb_render_control;
 
        fd4_emit_restore(ctx);
 
@@ -607,8 +596,8 @@ fd4_emit_tile_init(struct fd_context *ctx)
        update_vsc_pipe(ctx);
        patch_draws(ctx, IGNORE_VISIBILITY);
 
-       rb_render_control = 0; // XXX or BINNING_PASS.. but maybe we can emit only from gmem
-       patch_rbrc(ctx, rb_render_control);
+       OUT_PKT0(ring, REG_A4XX_RB_RENDER_CONTROL, 1);
+       OUT_RING(ring, 0x8);
 }
 
 /* before mem2gmem */
@@ -696,6 +685,9 @@ fd4_emit_tile_renderprep(struct fd_context *ctx, struct fd_tile *tile)
                        A4XX_GRAS_SC_SCREEN_SCISSOR_TL_Y(y1));
        OUT_RING(ring, A4XX_GRAS_SC_SCREEN_SCISSOR_BR_X(x2) |
                        A4XX_GRAS_SC_SCREEN_SCISSOR_BR_Y(y2));
+
+       OUT_PKT0(ring, REG_A4XX_RB_RENDER_CONTROL, 1);
+       OUT_RING(ring, 0x8);
 }
 
 void

diff --git a/src/gallium/drivers/freedreno/a4xx/fd4_zsa.c b/src/gallium/drivers/freedreno/a4xx/fd4_zsa.c
index e14b617570d0e3d48b40154190e1014b92e99f7e..a9c8d5a3d622c10118c5ddcff47b34fe90c1b3ad 100644 (file)
--- a/src/gallium/drivers/freedreno/a4xx/fd4_zsa.c
+++ b/src/gallium/drivers/freedreno/a4xx/fd4_zsa.c
@@ -103,7 +103,5 @@ fd4_zsa_state_create(struct pipe_context *pctx,
                        A4XX_RB_DEPTH_CONTROL_EARLY_Z_DISABLE;
        }
 
-       so->rb_render_control = 0x8;  /* XXX */
-
        return so;
 }

diff --git a/src/gallium/drivers/freedreno/a4xx/fd4_zsa.h b/src/gallium/drivers/freedreno/a4xx/fd4_zsa.h
index 6a92a9b6785ea0eb9e5724a7c4c1a0c12a6ceb18..3c46117a3fe3d00355f4c0440792fae8fca81236 100644 (file)
--- a/src/gallium/drivers/freedreno/a4xx/fd4_zsa.h
+++ b/src/gallium/drivers/freedreno/a4xx/fd4_zsa.h
@@ -39,7 +39,6 @@ struct fd4_zsa_stateobj {
        struct pipe_depth_stencil_alpha_state base;
        uint32_t gras_alpha_control;
        uint32_t rb_alpha_control;
-       uint32_t rb_render_control;
        uint32_t rb_depth_control;
        uint32_t rb_stencil_control;
        uint32_t rb_stencil_control2;