cso: fix sampler view count in cso_set_sampler_views()
authorBrian Paul <brianp@vmware.com>
Wed, 2 Apr 2014 14:54:41 +0000 (08:54 -0600)
committerBrian Paul <brianp@vmware.com>
Wed, 2 Apr 2014 19:58:05 +0000 (13:58 -0600)
We want to call pipe->set_sampler_views() with count being the
maximum of the old number of sampler views and the new number.
This makes sure we null-out any old sampler views.

We already do the same thing for sampler states in single_sampler_done().
Fixes some assertions seen in the VMware driver with XA tracker.

Cc: "10.0" "10.1" <mesa-stable@lists.freedesktop.org>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Tested-by: Thomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
src/gallium/auxiliary/cso_cache/cso_context.c

index 91466842c2e40a99622d477112e9be9b6d81c3eb..dda3c205e22413e92b230591e63bdfb492efdcdf 100644 (file)
@@ -1187,11 +1187,12 @@ cso_set_sampler_views(struct cso_context *ctx,
       pipe_sampler_view_reference(&info->views[i], NULL);
    }
 
-   info->nr_views = count;
-
    /* bind the new sampler views */
-   ctx->pipe->set_sampler_views(ctx->pipe, shader_stage, 0, count,
+   ctx->pipe->set_sampler_views(ctx->pipe, shader_stage, 0,
+                                MAX2(info->nr_views, count),
                                 info->views);
+
+   info->nr_views = count;
 }