2011-03-02 Michael Snyder <msnyder@vmware.com>

	* maint.c (maintenance_do_deprecate): No need to check for NULL.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0c61e0cd32cdef5b74ae0b81694b43ad822d883a..ee6802c9d58f2cae35e016a6888039236448dad9 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,7 @@
 2011-03-02  Michael Snyder  <msnyder@vmware.com>
 
+       * maint.c (maintenance_do_deprecate): No need to check for NULL.
+
        * cli/cli-script.c (script_from_file): Add break for lint.
 
        * mdebugread.c (parse_partial_symbols): Fix indent.

diff --git a/gdb/maint.c b/gdb/maint.c
index 101c2de61789847157de612b8f942e84f9c49197..ca9b3cca643fab16a1f9a7633d29263314cd7c08 100644 (file)
--- a/gdb/maint.c
+++ b/gdb/maint.c
@@ -644,9 +644,7 @@ maintenance_do_deprecate (char *text, int deprecate)
       cmd->flags |= MALLOCED_REPLACEMENT;
       return;
     }
-  /* If we get here, don't leak!  */
-  if (replacement != NULL)
-    xfree (replacement);
+  xfree (replacement);
 }
 
 /* Maintenance set/show framework.  */