i965/fs_surface_builder: Explicitly handle FORMAT_NONE in num_image_coordinates
authorJason Ekstrand <jason.ekstrand@intel.com>
Wed, 4 Nov 2015 23:12:19 +0000 (15:12 -0800)
committerJason Ekstrand <jason.ekstrand@intel.com>
Fri, 22 Apr 2016 03:44:27 +0000 (20:44 -0700)
Previously, we were relying on has_matching_typed_format returning true for
MESA_FORMAT_NONE which, in turn, relied on _mesa_get_format_bytes returning
1 for MESA_FORMAT_NONE.  When we switch to ISL, this behaviour will no
longer be something we can rely on.

Reviewed-by: Chad Versace <chad.versace@intel.com>
src/mesa/drivers/dri/i965/brw_fs_surface_builder.cpp

index 04d1cd220cf416814ae5eab27be19886146b9ae6..0932336c6da9fe1e21588834f69e22b23ce3d240 100644 (file)
@@ -410,6 +410,7 @@ namespace {
           * reads want the array index to be at the Z component.
           */
          const bool array_index_at_z =
+            format != MESA_FORMAT_NONE &&
             !image_format_info::has_matching_typed_format(
                bld.shader->devinfo, format);
          const unsigned zero_dims =