PR22127, as segfaults assembling invalid .reloc

"sec" gets set to NULL on errors in the offset expression.  This patch
disables part of the reloc expression processing that needs "sec"
valid.  I didn't disable the entire reloc expression handling so that
errors in the reloc expression are reported even when the offset
expression has an error.

	PR 22127
	* write.c (resolve_reloc_expr_symbols): Don't segfault when
	sec has been set to NULL.

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 1bbd8b8e7fea8b10f4e7b9895a2db079a052099a..86cf17e7eb8f2357b8bc5a518b12f2743fb65255 100644 (file)
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,9 @@
+2017-09-14  Alan Modra  <amodra@gmail.com>
+
+       PR 22127
+       * write.c (resolve_reloc_expr_symbols): Don't segfault when
+       sec has been set to NULL.
+
 2017-09-09  H.J. Lu  <hongjiu.lu@intel.com>
 
        * config/tc-i386.c (NOTRACK_PREFIX): Removed.

diff --git a/gas/write.c b/gas/write.c
index 4f6547dfb85bb0a15d63c58c5372453cdb960cc3..df88905013b9d12ab82000a5d20b137dd7cc4362 100644 (file)
--- a/gas/write.c
+++ b/gas/write.c
@@ -724,7 +724,7 @@ resolve_reloc_expr_symbols (void)
              as_bad_where (r->file, r->line, _("invalid reloc expression"));
              sec = NULL;
            }
-         else if (sym != NULL)
+         else if (sym != NULL && sec != NULL)
            {
              /* Convert relocs against local symbols to refer to the
                 corresponding section symbol plus offset instead.  Keep