gdb: move declaration of valprint_check_validity to valprint.h

The implementation is in valprint.c, so the declaration belongs in
valprint.h.

gdb/ChangeLog:

	* value.h (valprint_check_validity): Move declaration from
	here...
	* valprint.h (valprint_check_validity): ... to here.

Change-Id: Ibe577d3696720099e6d79888d4ee8e3c1bf05a26

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ec69531e6b554408d1dec38aaf2b13409c8119c0..642cb6441b3438e1455a0894dffac3d0520a3b91 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2020-08-24  Simon Marchi  <simon.marchi@polymtl.ca>
+
+       * value.h (valprint_check_validity): Move declaration from
+       here...
+       * valprint.h (valprint_check_validity): ... to here.
+
 2020-08-24  Simon Marchi  <simon.marchi@efficios.com>
 
        * debug.h: New file.

diff --git a/gdb/valprint.c b/gdb/valprint.c
index db98ca2abc986a84d6bc5ac3468a9f18fbdfe5d6..d95b1700bf714c0ab112ffa101aebe4d8ac9849d 100644 (file)
--- a/gdb/valprint.c
+++ b/gdb/valprint.c
@@ -301,7 +301,7 @@ val_print_scalar_or_string_type_p (struct type *type,
          || language->is_string_type_p (type));
 }
 
-/* See its definition in value.h.  */
+/* See valprint.h.  */
 
 int
 valprint_check_validity (struct ui_file *stream,

diff --git a/gdb/valprint.h b/gdb/valprint.h
index 57bc0339fcb7ce7e3bf3f27edae57a104f64015f..489d14ba0e908f1c661ad9f0561d95d03e8b9325 100644 (file)
--- a/gdb/valprint.h
+++ b/gdb/valprint.h
@@ -171,6 +171,20 @@ extern int read_string (CORE_ADDR addr, int len, int width,
                        gdb::unique_xmalloc_ptr<gdb_byte> *buffer,
                        int *bytes_read);
 
+/* Helper function to check the validity of some bits of a value.
+
+   If TYPE represents some aggregate type (e.g., a structure), return 1.
+
+   Otherwise, any of the bytes starting at OFFSET and extending for
+   TYPE_LENGTH(TYPE) bytes are invalid, print a message to STREAM and
+   return 0.  The checking is done using FUNCS.
+
+   Otherwise, return 1.  */
+
+extern int valprint_check_validity (struct ui_file *stream, struct type *type,
+                                   LONGEST embedded_offset,
+                                   const struct value *val);
+
 extern void val_print_optimized_out (const struct value *val,
                                     struct ui_file *stream);
 

diff --git a/gdb/value.h b/gdb/value.h
index 12e4a13e3e40fd672d3c48589244c4416e289802..f7d57d125421d68963db2090a57ab284be1fb206 100644 (file)
--- a/gdb/value.h
+++ b/gdb/value.h
@@ -302,20 +302,6 @@ extern struct value *allocate_computed_value (struct type *type,
                                              const struct lval_funcs *funcs,
                                              void *closure);
 
-/* Helper function to check the validity of some bits of a value.
-
-   If TYPE represents some aggregate type (e.g., a structure), return 1.
-   
-   Otherwise, any of the bytes starting at OFFSET and extending for
-   TYPE_LENGTH(TYPE) bytes are invalid, print a message to STREAM and
-   return 0.  The checking is done using FUNCS.
-   
-   Otherwise, return 1.  */
-
-extern int valprint_check_validity (struct ui_file *stream, struct type *type,
-                                   LONGEST embedded_offset,
-                                   const struct value *val);
-
 extern struct value *allocate_optimized_out_value (struct type *type);
 
 /* If VALUE is lval_computed, return its lval_funcs structure.  */