[PR86064] split single cross-partition range with nonzero locviews

We didn't split cross-partition ranges in loclists to output a
whole-function location expression, but with nonzero locviews, we
force loclists, and then we have to split to avoid cross-partition
list entries.

for  gcc/ChangeLog

	PR debug/86064
	* dwarf2out.c (loc_list_has_views): Adjust comments.
	(dw_loc_list): Split single cross-partition range with
	nonzero locview.

for  gcc/testsuite/ChangeLog

	PR debug/86064
	* gcc.dg/pr86064.c: New.

From-SVN: r262130

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index b5f073de6638f180059bdf79cde8ac9488d0e3ec..d420310e07310076aa063cf5b9b11c08ebbe081d 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,10 @@
+2018-06-26  Alexandre Oliva <aoliva@redhat.com>
+
+       PR debug/86064
+       * dwarf2out.c (loc_list_has_views): Adjust comments.
+       (dw_loc_list): Split single cross-partition range with
+       nonzero locview.
+
 2018-06-25  Jeff Law  <law@redhat.com>
 
        * config/v850/predicates.md (const_float_1_operand): Fix match_code

diff --git a/gcc/dwarf2out.c b/gcc/dwarf2out.c
index 80323641d2cefa5524f0e041694dc11b2c45f196..b5e3134930738f9f6bf168f1d8e5c41eb5a5c187 100644 (file)
--- a/gcc/dwarf2out.c
+++ b/gcc/dwarf2out.c
@@ -10029,7 +10029,15 @@ new_loc_list (dw_loc_descr_ref expr, const char *begin, var_loc_view vbegin,
   return retlist;
 }
 
-/* Return true iff there's any nonzero view number in the loc list.  */
+/* Return true iff there's any nonzero view number in the loc list.
+
+   ??? When views are not enabled, we'll often extend a single range
+   to the entire function, so that we emit a single location
+   expression rather than a location list.  With views, even with a
+   single range, we'll output a list if start or end have a nonzero
+   view.  If we change this, we may want to stop splitting a single
+   range in dw_loc_list just because of a nonzero view, even if it
+   straddles across hot/cold partitions.  */
 
 static bool
 loc_list_has_views (dw_loc_list_ref list)
@@ -17139,7 +17147,13 @@ dw_loc_list (var_loc_list *loc_list, tree decl, int want_address)
                 of first partition and second one starting at the
                 beginning of second partition.  */
              if (node == loc_list->last_before_switch
-                 && (node != loc_list->first || loc_list->first->next)
+                 && (node != loc_list->first || loc_list->first->next
+                     /* If we are to emit a view number, we will emit
+                        a loclist rather than a single location
+                        expression for the entire function (see
+                        loc_list_has_views), so we have to split the
+                        range that straddles across partitions.  */
+                     || !ZERO_VIEW_P (node->view))
                  && current_function_decl)
                {
                  endname = cfun->fde->dw_fde_end;

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 5c0de04c4cb81d92b2f1ad56ee32113edde24ebb..5d5ed667afc715e4b2135f89c17fb5afeb9e9acf 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2018-06-26  Alexandre Oliva <aoliva@redhat.com>
+
+       PR debug/86064
+       * gcc.dg/pr86064.c: New.
+
 2018-06-25  Jeff Law  <law@redhat.com>
 
        * lib/target-supports.exp

diff --git a/gcc/testsuite/gcc.dg/pr86064.c b/gcc/testsuite/gcc.dg/pr86064.c
new file mode 100644 (file)
index 0000000..5be820c
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr86064.c
@@ -0,0 +1,27 @@
+/* { dg-do compile } */
+/* { dg-options "-g -O2 -fno-var-tracking-assignments -gsplit-dwarf" } */
+
+/* This used to fail with location views (implicitly) enabled, because
+   var-tracking (not at assignments) creates a range for d starting at
+   the load after the first call, and we did not split the range,
+   despite its crossing between hot and cold partitions, because it's
+   a single range, that we normally extend to the entire function.
+   However, because the range starts at a (presumed) nonzero view, we
+   end up outputting a loclist instead of a single location entry.
+   But then, -gsplit-dwarf selects (startx,length) loclist entries,
+   and the length ends up computing the difference between symbols in
+   different subsections.  */
+
+int a;
+__attribute__((__cold__)) void b();
+
+void e(int *);
+int f();
+
+void c() {
+  int d;
+  e(&d);
+  a = d;
+  if (f())
+    b();
+}