Make gdb.base/solib-nodir.exp work with --target_board=native-extended-gdbserver
authorPedro Alves <palves@redhat.com>
Fri, 13 Oct 2017 09:26:06 +0000 (10:26 +0100)
committerPedro Alves <palves@redhat.com>
Fri, 13 Oct 2017 09:29:30 +0000 (10:29 +0100)
Fixes:
 Running .../src/gdb/testsuite/gdb.base/solib-nodir.exp ...
 FAIL: gdb.base/solib-nodir.exp: library loaded

... by using the new "set cwd" command.

gdb/testsuite/ChangeLog:
2017-10-13  Pedro Alves  <palves@redhat.com>
    Simon Marchi <simon.marchi@polymtl.ca>

* gdb.base/solib-nodir.exp: Split is_remote and skip_shlib_tests
calls and add comments.  Skip test if use_gdb_stub is set.
(top level): Use "set cwd" command instead of "cd" command.

gdb/testsuite/ChangeLog
gdb/testsuite/gdb.base/solib-nodir.exp

index 9aac613e24730d8ba7db91b55b541e1f237ff829..b37da2a1fef0f127fc599ca1e908df8b3cc18ced 100644 (file)
@@ -1,3 +1,10 @@
+2017-10-13  Pedro Alves  <palves@redhat.com>
+           Simon Marchi  <simon.marchi@polymtl.ca>
+
+       * gdb.base/solib-nodir.exp: Split is_remote and skip_shlib_tests
+       calls and add comments.  Skip test if use_gdb_stub is set.
+       (top level): Use "set cwd" command instead of "cd" command.
+
 2017-10-13  Pedro Alves  <palves@redhat.com>
 
        * gdb.base/shlib-call.exp (top level): Use gdb_run_cmd and remove
index 9cb682e863cb8cd2925fffb5e2a4f099a1bb6a09..15673d17a07422e00f5fa4a9ac0c151d6ad6cd4b 100644 (file)
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
-# are we on a target board
-if {[is_remote target] || [skip_shlib_tests]} {
+if [skip_shlib_tests] {
+    return
+}
+
+# The testcase assumes the target can access the OBJDIR.
+if [is_remote target] {
+    return
+}
+
+# We need to be able to influence the target's environment and working
+# directory.  Can't do that if when we connect the inferior is already
+# running.
+if [target_info exists use_gdb_stub] {
     return
 }
 
@@ -44,7 +55,8 @@ clean_restart $executable
 gdb_load_shlib ${binlibfile}
 
 gdb_test_no_output "set env LD_LIBRARY_PATH=:"
-gdb_test "cd ${binlibfiledir}" "Working directory [string_to_regexp ${binlibfiledir}]\\." "cd OBJDIR/${subdir}"
+gdb_test_no_output "set cwd ${binlibfiledir}" \
+    "set cwd OBJDIR/${subdir}"
 
 set test "library loaded"
 if [runto_main] {