iris: Drop XXX about alpha testing
authorKenneth Graunke <kenneth@whitecape.org>
Mon, 11 Feb 2019 19:40:38 +0000 (11:40 -0800)
committerKenneth Graunke <kenneth@whitecape.org>
Thu, 21 Feb 2019 18:26:12 +0000 (10:26 -0800)
I was misreading i965 - the 3DSTATE_WM::PixelShaderKillsPixel bit from
Gen < 8 needed all of this, but the 3DSTATE_PS_EXTRA bit only needs
prog_data->uses_kill.

src/gallium/drivers/iris/iris_state.c

index 2cf9c62587e2a72025810f723c6183684f779c94..8191141a373e874b371ea0d9a9c4b7b97c4a58c0 100644 (file)
@@ -3392,9 +3392,7 @@ iris_store_fs_state(struct iris_context *ice,
    iris_pack_command(GENX(3DSTATE_PS_EXTRA), psx_state, psx) {
       psx.PixelShaderValid = true;
       psx.PixelShaderComputedDepthMode = wm_prog_data->computed_depth_mode;
-      // XXX: alpha test / alpha to coverage :/
-      psx.PixelShaderKillsPixel = wm_prog_data->uses_kill ||
-                                  wm_prog_data->uses_omask;
+      psx.PixelShaderKillsPixel = wm_prog_data->uses_kill;
       psx.AttributeEnable = wm_prog_data->num_varying_inputs != 0;
       psx.PixelShaderUsesSourceDepth = wm_prog_data->uses_src_depth;
       psx.PixelShaderUsesSourceW = wm_prog_data->uses_src_w;