* doublest.c (floatformat_mantissa): Use xsnprintf instead of

sprintf.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 63c6b954ddb7c095f79ab647bb43b17f1cc56b93..c6d2c595128f653ed65440dc7b53ae6321ec4b8c 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,8 @@
 2005-08-21  Mark Kettenis  <kettenis@gnu.org>
 
+       * doublest.c (floatformat_mantissa): Use xsnprintf instead of
+       sprintf.
+
        * vaxobsd-tdep.c: New file.
        * config/vax/obsd.mt (TDEPFILES): Add vaxobsd-tdep.o.
        * Makefile.in (vaxobsd-tdep.o): New dependency.

diff --git a/gdb/doublest.c b/gdb/doublest.c
index 361b4b269be139a0708826e30e8cdea1d08bfadc..2562ab672387b470144848be7518bad394734a1a 100644 (file)
--- a/gdb/doublest.c
+++ b/gdb/doublest.c
@@ -558,6 +558,7 @@ floatformat_mantissa (const struct floatformat *fmt,
   int mant_bits_left;
   static char res[50];
   char buf[9];
+  int len;
   enum floatformat_byteorders order;
   unsigned char newfrom[FLOATFORMAT_LARGEST_BYTES];
   
@@ -582,16 +583,17 @@ floatformat_mantissa (const struct floatformat *fmt,
 
   mant = get_field (uval, order, fmt->totalsize, mant_off, mant_bits);
 
-  sprintf (res, "%lx", mant);
+  len = xsnprintf (res, sizeof res, "%lx", mant);
 
   mant_off += mant_bits;
   mant_bits_left -= mant_bits;
-  
+
   while (mant_bits_left > 0)
     {
       mant = get_field (uval, order, fmt->totalsize, mant_off, 32);
 
-      sprintf (buf, "%08lx", mant);
+      xsnprintf (buf, sizeof buf, "%08lx", mant);
+      gdb_assert (len + strlen (buf) <= sizeof res);
       strcat (res, buf);
 
       mant_off += 32;