broadcom/vc5: Fix setup of TF dword output count.
authorEric Anholt <eric@anholt.net>
Mon, 2 Oct 2017 19:05:30 +0000 (12:05 -0700)
committerEric Anholt <eric@anholt.net>
Tue, 10 Oct 2017 18:42:05 +0000 (11:42 -0700)
I missed the "- 1" when reading the spec.

src/broadcom/cle/v3d_packet_v33.xml
src/gallium/drivers/vc5/vc5_program.c

index bbfe0a991db479816a5f12b4b099194efee5ae46..06ca0365ef3e30e3c5dc7b8311e0cd70846a3d64 100644 (file)
 
   <struct name="Transform Feedback Output Data Spec">
     <field name="First Shaded Vertex Value to output" size="8" start="0" type="uint"/>
-    <field name="Number of consecutive Vertex Values to output as 32-bit values" size="4" start="8" type="uint"/>
+    <field name="Number of consecutive Vertex Values to output as 32-bit values minus 1" size="4" start="8" type="uint"/>
     <field name="Output Buffer to write to" size="2" start="12" type="uint"/>
   </struct>
 
index 107c9c0533507816f322bbd89f86a4730b04d797..d3b3d1bee702fe4fc063130611835ab26810d4bb 100644 (file)
@@ -87,7 +87,7 @@ vc5_set_transform_feedback_outputs(struct vc5_uncompiled_shader *so,
 
                 struct V3D33_TRANSFORM_FEEDBACK_OUTPUT_DATA_SPEC unpacked = {
                         .first_shaded_vertex_value_to_output = vpm_start,
-                        .number_of_consecutive_vertex_values_to_output_as_32_bit_values = vpm_size,
+                        .number_of_consecutive_vertex_values_to_output_as_32_bit_values_minus_1 = vpm_size - 1,
                         .output_buffer_to_write_to = buffer,
                 };
                 V3D33_TRANSFORM_FEEDBACK_OUTPUT_DATA_SPEC_pack(NULL,