mem-ruby: Removed the unused parameter m_id from VirtualChannel
authorNikos Nikoleris <nikos.nikoleris@arm.com>
Thu, 23 Apr 2020 17:57:57 +0000 (18:57 +0100)
committerNikos Nikoleris <nikos.nikoleris@arm.com>
Thu, 30 Apr 2020 09:14:42 +0000 (09:14 +0000)
Change-Id: Ie6f8db9b1cb0d0e0ca694c631c6662413fd833c1
Signed-off-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Reviewed-by: Giacomo Travaglini <giacomo.travaglini@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/28171
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com>
Reviewed-by: Srikant Bharadwaj <srikant.bharadwaj@amd.com>
Maintainer: Bobby R. Bruce <bbruce@ucdavis.edu>
Tested-by: kokoro <noreply+kokoro@google.com>
src/mem/ruby/network/garnet2.0/InputUnit.cc
src/mem/ruby/network/garnet2.0/VirtualChannel.cc
src/mem/ruby/network/garnet2.0/VirtualChannel.hh

index 8fdce067b9e36bba11f6aa192d920ae42fbe4eaf..640e3b4ace83d8203d9b0d0deac4183457f065a6 100644 (file)
@@ -52,7 +52,7 @@ InputUnit::InputUnit(int id, PortDirection direction, Router *router)
     // Instantiating the virtual channels
     virtualChannels.reserve(m_num_vcs);
     for (int i=0; i < m_num_vcs; i++) {
-        virtualChannels.emplace_back(i);
+        virtualChannels.emplace_back();
     }
 }
 
index 3b077d4f35fcbd453f7699a6f8da939051bbef2a..a469a84fd4e69a43593d381135c002803e8915f8 100644 (file)
@@ -31,8 +31,8 @@
 
 #include "mem/ruby/network/garnet2.0/VirtualChannel.hh"
 
-VirtualChannel::VirtualChannel(int id)
-  : m_id(id), inputBuffer(), m_vc_state(IDLE_, Cycles(0)), m_output_port(-1),
+VirtualChannel::VirtualChannel()
+  : inputBuffer(), m_vc_state(IDLE_, Cycles(0)), m_output_port(-1),
     m_enqueue_time(INFINITE_), m_output_vc(-1)
 {
 }
index 52963c8ac54c22fd03a518b6ffe1506678b3f8d0..752dfb440f035ea71c99f26407b378a84ed5ba77 100644 (file)
@@ -40,7 +40,7 @@
 class VirtualChannel
 {
   public:
-    VirtualChannel(int id);
+    VirtualChannel();
     ~VirtualChannel() = default;
 
     bool need_stage(flit_stage stage, Cycles time);
@@ -89,7 +89,6 @@ class VirtualChannel
     uint32_t functionalWrite(Packet *pkt);
 
   private:
-    int m_id;
     flitBuffer inputBuffer;
     std::pair<VC_state_type, Cycles> m_vc_state;
     int m_output_port;