2011-02-22 Michael Snyder <msnyder@vmware.com>

	* cli/cli-utils.c (number_is_in_list): Check for zero return.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 1859bf0ffc703ae1ab48307c4cfb489ff4f40dc6..2451004a50546271f9acbb371c3433b8b9311e3d 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2011-02-22  Michael Snyder  <msnyder@vmware.com>
+
+       * cli/cli-utils.c (number_is_in_list): Check for zero return.
+
 2011-02-22  Pedro Alves  <pedro@codesourcery.com>
 
        * frame-unwind.h: Fix comment to mention the this frame, not the

diff --git a/gdb/cli/cli-utils.c b/gdb/cli/cli-utils.c
index 8a7e5d40d316c38f17ac18a8c7d72ad784d0ff08..34c368be9c58fe9c7a0a104d5e2dee0327e5351b 100644 (file)
--- a/gdb/cli/cli-utils.c
+++ b/gdb/cli/cli-utils.c
@@ -175,10 +175,15 @@ number_is_in_list (char *list, int number)
   if (list == NULL || *list == '\0')
     return 1;
 
-  while (list != NULL && *list != '\0')
-    if (get_number_or_range (&list) == number)
-      return 1;
+  while (*list != '\0')
+    {
+      int gotnum = get_number_or_range (&list);
 
+      if (gotnum == 0)
+       error (_("Args must be numbers or '$' variables."));
+      if (gotnum == number)
+       return 1;
+    }
   return 0;
 }