compiler: handle int-to-string conversion with large integer constant

    Currently, Type_conversion_expression::do_is_constant thinks the
    int-to-string conversion is constant if the integer operand is
    constant, but Type_conversion_expression::do_get_backend actually
    generates a call to runtime.intstring if the integer does not fit
    in a "ushort", which makes it not suitable in constant context,
    such as static initializer.

    This CL makes it handle all constant integer input as constant,
    generating constant string.

    Fixes golang/go#32347.

    Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/179777

From-SVN: r271821

diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofrontend/MERGE
index 72268229fbcc0ad6d17d73aa1971b1221731502e..420248b6262e44b0c5cd1faad74a247a1576784e 100644 (file)
--- a/gcc/go/gofrontend/MERGE
+++ b/gcc/go/gofrontend/MERGE
@@ -1,4 +1,4 @@
-8402f6ac021ba20163ab4fcdb10ab7bb642de6dc
+e521123b23494148d534755e2f3d7806b42c96ad
 
 The first line of this file holds the git revision number of the last
 merge done from the gofrontend repository.

diff --git a/gcc/go/gofrontend/expressions.cc b/gcc/go/gofrontend/expressions.cc
index e3a662736a0907794bd2c3a7f533e19f23bb2341..f0c12f42ce3aa331457195112eaf863fa5105335 100644 (file)
--- a/gcc/go/gofrontend/expressions.cc
+++ b/gcc/go/gofrontend/expressions.cc
@@ -3842,11 +3842,20 @@ Type_conversion_expression::do_get_backend(Translate_context* context)
       mpz_t intval;
       Numeric_constant nc;
       if (this->expr_->numeric_constant_value(&nc)
-         && nc.to_int(&intval)
-         && mpz_fits_ushort_p(intval))
+         && nc.to_int(&intval))
        {
          std::string s;
-         Lex::append_char(mpz_get_ui(intval), true, &s, loc);
+          unsigned int x;
+          if (mpz_fits_uint_p(intval))
+            x = mpz_get_ui(intval);
+          else
+            {
+              char* s = mpz_get_str(NULL, 16, intval);
+              go_warning_at(loc, 0,
+                            "unicode code point 0x%s out of range in string", s);
+              x = 0xfffd;
+            }
+         Lex::append_char(x, true, &s, loc);
          mpz_clear(intval);
          Expression* se = Expression::make_string(s, loc);
          return se->get_backend(context);