Remove buildsym_new_init

buildsym_new_init is just an alias for buildsym_init.  This removes
it.  In the long run buildsym_init will also go away; this patch just
helps make things a bit clearer in the meantime.

gdb/ChangeLog
2018-07-16  Tom Tromey  <tom@tromey.com>

	* xcoffread.c (xcoff_new_init): Update.
	* mipsread.c (mipscoff_new_init): Update.
	* mdebugread.c (mdebug_build_psymtabs): Update.
	* elfread.c (elf_new_init): Update.
	* dbxread.c (dbx_new_init, coffstab_build_psymtabs)
	(elfstab_build_psymtabs, stabsect_build_psymtabs): Update.
	* buildsym.h (buildsym_new_init): Don't declare.
	* buildsym.c (buildsym_new_init): Remove.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 74573a8f83c31be2ed8afc575b10ec60c9e0536e..f80318288b1d0fff4acce17b83c2ac0998c6ea18 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,14 @@
+2018-07-16  Tom Tromey  <tom@tromey.com>
+
+       * xcoffread.c (xcoff_new_init): Update.
+       * mipsread.c (mipscoff_new_init): Update.
+       * mdebugread.c (mdebug_build_psymtabs): Update.
+       * elfread.c (elf_new_init): Update.
+       * dbxread.c (dbx_new_init, coffstab_build_psymtabs)
+       (elfstab_build_psymtabs, stabsect_build_psymtabs): Update.
+       * buildsym.h (buildsym_new_init): Don't declare.
+       * buildsym.c (buildsym_new_init): Remove.
+
 2018-07-16  Tom Tromey  <tom@tromey.com>
 
        * stabsread.h (within_function): Move from buildsym.h.

diff --git a/gdb/buildsym.c b/gdb/buildsym.c
index fea43645e7c87f2c80e79e49ab4736d49c5cf453..a87f58a6bf6fc1894dadaae7846f899696593386 100644 (file)
--- a/gdb/buildsym.c
+++ b/gdb/buildsym.c
@@ -1751,7 +1751,7 @@ get_last_source_start_addr ()
    corresponding to a psymtab.  */
 
 void
-buildsym_init (void)
+buildsym_init ()
 {
   subfile_stack = NULL;
 
@@ -1775,13 +1775,3 @@ buildsym_init (void)
   gdb_assert (pending_addrmap == NULL);
   gdb_assert (buildsym_compunit == NULL);
 }
-
-/* Initialize anything that needs initializing when a completely new
-   symbol file is specified (not just adding some symbols from another
-   file, e.g. a shared library).  */
-
-void
-buildsym_new_init (void)
-{
-  buildsym_init ();
-}

diff --git a/gdb/buildsym.h b/gdb/buildsym.h
index a6bed3c6119172f2b9cd3a25450b60319f16d002..77fc5bdd3c42db781ce088221eb02867e74562d5 100644 (file)
--- a/gdb/buildsym.h
+++ b/gdb/buildsym.h
@@ -209,9 +209,7 @@ extern void augment_type_symtab (void);
 
 extern void scan_file_globals (struct objfile *objfile);
 
-extern void buildsym_new_init (void);
-
-extern void buildsym_init (void);
+extern void buildsym_init ();
 
 extern struct context_stack *push_context (int desc, CORE_ADDR valu);
 

diff --git a/gdb/dbxread.c b/gdb/dbxread.c
index ba0483ed8622ccb53bb73e2bfc88a317ef35e0af..7729315adb62bcceda8376a8c2fb0e0decf1b318 100644 (file)
--- a/gdb/dbxread.c
+++ b/gdb/dbxread.c
@@ -568,7 +568,7 @@ static void
 dbx_new_init (struct objfile *ignore)
 {
   stabsread_new_init ();
-  buildsym_new_init ();
+  buildsym_init ();
   init_header_files ();
 }
 
@@ -3037,7 +3037,7 @@ coffstab_build_psymtabs (struct objfile *objfile,
     perror_with_name (name);
 
   stabsread_new_init ();
-  buildsym_new_init ();
+  buildsym_init ();
   free_header_files ();
   init_header_files ();
 
@@ -3125,7 +3125,7 @@ elfstab_build_psymtabs (struct objfile *objfile, asection *stabsect,
     perror_with_name (name);
 
   stabsread_new_init ();
-  buildsym_new_init ();
+  buildsym_init ();
   free_header_files ();
   init_header_files ();
 
@@ -3227,7 +3227,7 @@ stabsect_build_psymtabs (struct objfile *objfile, char *stab_name,
     perror_with_name (name);
 
   stabsread_new_init ();
-  buildsym_new_init ();
+  buildsym_init ();
   free_header_files ();
   init_header_files ();
 

diff --git a/gdb/elfread.c b/gdb/elfread.c
index feca5ea85b79b04127df4b41557133252c47ef88..a5c4cdf4fe84f706d5dc73e031ba0f595f5f73dc 100644 (file)
--- a/gdb/elfread.c
+++ b/gdb/elfread.c
@@ -1325,7 +1325,7 @@ static void
 elf_new_init (struct objfile *ignore)
 {
   stabsread_new_init ();
-  buildsym_new_init ();
+  buildsym_init ();
 }
 
 /* Perform any local cleanups required when we are done with a particular

diff --git a/gdb/mdebugread.c b/gdb/mdebugread.c
index 98f10b465e580e98f8e10a0d7dae0c4d9ed6d5f1..8b1db999773d7fe32785890db5f52e8ff650035b 100644 (file)
--- a/gdb/mdebugread.c
+++ b/gdb/mdebugread.c
@@ -344,7 +344,7 @@ mdebug_build_psymtabs (minimal_symbol_reader &reader,
   debug_info = info;
 
   stabsread_new_init ();
-  buildsym_new_init ();
+  buildsym_init ();
   free_header_files ();
   init_header_files ();
         

diff --git a/gdb/mipsread.c b/gdb/mipsread.c
index 7b6ec2e48d3b2a98c3792a1e2d91c5e7526f6200..3bdc50733d843e2b1e326034cbbc5bd2f4631173 100644 (file)
--- a/gdb/mipsread.c
+++ b/gdb/mipsread.c
@@ -54,7 +54,7 @@ static void
 mipscoff_new_init (struct objfile *ignore)
 {
   stabsread_new_init ();
-  buildsym_new_init ();
+  buildsym_init ();
 }
 
 /* Initialize to read a symbol file (nothing to do).  */

diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c
index 6d4dfd95e64c543e9de4732cc60daa8cef0035e0..31ba503f8ac5b62353783dd9cd846c12a3010815 100644 (file)
--- a/gdb/xcoffread.c
+++ b/gdb/xcoffread.c
@@ -1920,7 +1920,7 @@ static void
 xcoff_new_init (struct objfile *objfile)
 {
   stabsread_new_init ();
-  buildsym_new_init ();
+  buildsym_init ();
 }
 
 /* Do initialization in preparation for reading symbols from OBJFILE.