Added $bits() for memories as well.
authorUdi Finkelstein <github@udifink.com>
Tue, 26 Sep 2017 06:11:25 +0000 (09:11 +0300)
committerUdi Finkelstein <github@udifink.com>
Tue, 26 Sep 2017 06:11:25 +0000 (09:11 +0300)
frontends/ast/simplify.cc
tests/simple/functions01.sv

index 608df0cb95fe35f54bf1e32a54f83f013711fd4c..0cde34dc51dc5577dd816cfeea89e6a8fc23ec5d 100644 (file)
@@ -1870,19 +1870,43 @@ skip_dynamic_range_lvalue_expansion:;
                                goto apply_newNode;
                        }
 
-                       if (str == "\\$size")
+                       if (str == "\\$size" || str == "\\$bits")
                        {
                                if (children.size() != 1)
                                        log_error("System function %s got %d arguments, expected 1 at %s:%d.\n",
                                                        RTLIL::unescape_id(str).c_str(), int(children.size()), filename.c_str(), linenum);
 
                                AstNode *buf = children[0]->clone();
+                               int mem_depth = 1;
+                               AstNode *id_ast = NULL;
+                               
                                // Is this needed?
                                //while (buf->simplify(true, false, false, stage, width_hint, sign_hint, false)) { }
                                buf->detectSignWidth(width_hint, sign_hint);
+                               if (str == "\\$bits") {
+                                       if (buf->type == AST_IDENTIFIER) {
+                                               id_ast = buf->id2ast;
+                                               if (id_ast == NULL && current_scope.count(buf->str))
+                                                       id_ast = current_scope.at(buf->str);
+                                               if (!id_ast)
+                                                       log_error("Failed to resolve identifier %s for width detection at %s:%d!\n", buf->str.c_str(), filename.c_str(), linenum);
+                                               if (id_ast->type == AST_MEMORY) {
+                                                       AstNode *mem_range = id_ast->children[1];
+                                                       if (mem_range->type == AST_RANGE) {
+                                                               if (!mem_range->range_valid)
+                                                                       log_error("Failed to detect width of memory access `%s' at %s:%d!\n", mem_range->str.c_str(), filename.c_str(), linenum);
+                                                               mem_depth = mem_range->range_left - mem_range->range_right + 1;
+                                                       } else if (mem_range->type == AST_MULTIRANGE) {
+                                                               for (auto n : mem_range->children) 
+                                                                       mem_depth *= (n->range_left - n->range_right + 1);
+                                                       } else
+                                                               log_error("Unknown memory depth AST type in `%s' at %s:%d!\n", mem_range->str.c_str(), filename.c_str(), linenum);
+                                               }
+                                       }
+                               }
                                delete buf;
 
-                               newNode = mkconst_int(width_hint, false);
+                               newNode = mkconst_int(width_hint * mem_depth, false);
                                goto apply_newNode;
                        }
 
index cd87a49b717cbbb85231161d9b212fa8d5a3a9a4..d6cd53e07c80983fdf2dc791150d2e2cd2f359c1 100644 (file)
@@ -1,4 +1,5 @@
 module functions01;
+
 wire [3:0]x;
 wire [$size(x)-1:0]x_size;
 wire [$size({x, x})-1:0]xx_size;
@@ -7,11 +8,9 @@ wire [$size(y)-1:0]y_size;
 wire [3:0]z[0:5][0:7];
 wire [$size(z)-1:0]z_size;
 
-//
-// The following are not supported yet:
-//
-
-//wire [$bits(x)-1:0]x_bits;
-//wire [$bits({x, x})-1:0]xx_bits;
+wire [$bits(x)-1:0]x_bits;
+wire [$bits({x, x})-1:0]xx_bits;
+wire [$bits(y)-1:0]y_bits;
+wire [$bits(z)-1:0]z_bits;
 
 endmodule