pan/midgard: Add no_spill flag

Hint for the RA to avoid infinite spilling loops.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>

diff --git a/src/panfrost/midgard/compiler.h b/src/panfrost/midgard/compiler.h
index 38bf1ecfaca0bbe03043addc3b0c797738453e4f..d62157f3be4f2c605a40fad1684b2a9c2a2bba1a 100644 (file)
--- a/src/panfrost/midgard/compiler.h
+++ b/src/panfrost/midgard/compiler.h
@@ -129,6 +129,11 @@ typedef struct midgard_instruction {
 
         bool invert;
 
+        /* Hint for the register allocator not to spill the destination written
+         * from this instruction (because it is a spill/unspill node itself) */
+
+        bool no_spill;
+
         union {
                 midgard_load_store_word load_store;
                 midgard_vector_alu alu;

diff --git a/src/panfrost/midgard/midgard_schedule.c b/src/panfrost/midgard/midgard_schedule.c
index d7d8254bd6b18312f17f709305ac145ab927bb1f..958e109346b60605e82459099e9c24afc1966e8e 100644 (file)
--- a/src/panfrost/midgard/midgard_schedule.c
+++ b/src/panfrost/midgard/midgard_schedule.c
@@ -717,7 +717,10 @@ v_load_store_scratch(
                         /* Splattered across, TODO combine logically */
                         .varying_parameters = (byte & 0x1FF) << 1,
                         .address = (byte >> 9)
-                }
+                },
+
+                /* If we spill an unspill, RA goes into an infinite loop */
+                .no_spill = true
         };
 
        if (is_store) {
@@ -752,11 +755,10 @@ static void mir_spill_register(
         }
 
         mir_foreach_instr_global(ctx, ins) {
-                if (ins->type != TAG_LOAD_STORE_4)  continue;
-                if (ins->load_store.op != midgard_op_ld_int4) continue;
-                if (ins->load_store.arg_1 != 0xEA) continue;
-                if (ins->load_store.arg_2 != 0x1E) continue;
-                ra_set_node_spill_cost(g, ins->ssa_args.dest, -1.0);
+                if (ins->no_spill &&
+                    ins->ssa_args.dest >= 0 &&
+                    ins->ssa_args.dest < ctx->temp_count)
+                        ra_set_node_spill_cost(g, ins->ssa_args.dest, -1.0);
         }
 
         int spill_node = ra_get_best_spill_node(g);
@@ -791,6 +793,7 @@ static void mir_spill_register(
                         if (is_special_w) {
                                 spill_slot = spill_index++;
                                 st = v_mov(spill_node, blank_alu_src, spill_slot);
+                                st.no_spill = true;
                         } else {
                                 ins->ssa_args.dest = SSA_FIXED_REGISTER(26);
                                 st = v_load_store_scratch(ins->ssa_args.dest, spill_slot, true, ins->mask);
@@ -852,6 +855,7 @@ static void mir_spill_register(
                                 if (is_special) {
                                         /* Move */
                                         st = v_mov(spill_node, blank_alu_src, consecutive_index);
+                                        st.no_spill = true;
                                 } else {
                                         /* TLS load */
                                         st = v_load_store_scratch(consecutive_index, spill_slot, false, 0xF);