i915: Silence unused parameter warning in intel_miptree_create_layout
authorIan Romanick <ian.d.romanick@intel.com>
Wed, 2 Sep 2015 22:11:34 +0000 (15:11 -0700)
committerIan Romanick <ian.d.romanick@intel.com>
Fri, 11 Sep 2015 03:29:51 +0000 (20:29 -0700)
The for_bo parameter of intel_miptree_create_layout appears to be unused
since 27eedca when Eric removed some Gen5 code (after the i915 and i965
drivers parted ways).

intel_mipmap_tree.c: In function 'old_intel_miptree_create_layout':
intel_mipmap_tree.c:77:35: warning: unused parameter 'for_bo' [-Wunused-parameter]
                             bool for_bo)
                                   ^

Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>
src/mesa/drivers/dri/i915/intel_mipmap_tree.c
src/mesa/drivers/dri/i915/intel_mipmap_tree.h
src/mesa/drivers/dri/i915/intel_tex_image.c

index 307ad4df8915d72cc8386dbb536aff6c0f6b4065..5cbf7634fcc2269debfd6d6a6a35584fa111e9ba 100644 (file)
@@ -60,11 +60,6 @@ target_to_target(GLenum target)
    }
 }
 
-/**
- * @param for_bo Indicates that the caller is
- *        intel_miptree_create_for_bo(). If true, then do not create
- *        \c stencil_mt.
- */
 struct intel_mipmap_tree *
 intel_miptree_create_layout(struct intel_context *intel,
                             GLenum target,
@@ -73,8 +68,7 @@ intel_miptree_create_layout(struct intel_context *intel,
                             GLuint last_level,
                             GLuint width0,
                             GLuint height0,
-                            GLuint depth0,
-                            bool for_bo)
+                            GLuint depth0)
 {
    struct intel_mipmap_tree *mt = calloc(sizeof(*mt), 1);
    if (!mt)
@@ -181,8 +175,7 @@ intel_miptree_create(struct intel_context *intel,
 
    mt = intel_miptree_create_layout(intel, target, format,
                                      first_level, last_level, width0,
-                                     height0, depth0,
-                                     false);
+                                     height0, depth0);
    /*
     * pitch == 0 || height == 0  indicates the null texture
     */
@@ -262,8 +255,7 @@ intel_miptree_create_for_bo(struct intel_context *intel,
 
    mt = intel_miptree_create_layout(intel, GL_TEXTURE_2D, format,
                                     0, 0,
-                                    width, height, 1,
-                                    true);
+                                    width, height, 1);
    if (!mt) {
       free(region);
       return mt;
index aab30ed1f557b9a422446f2251fe51e206faff1c..2520b3035b240e6f113c13c42e21a95b802da53e 100644 (file)
@@ -240,8 +240,7 @@ intel_miptree_create_layout(struct intel_context *intel,
                             GLuint last_level,
                             GLuint width0,
                             GLuint height0,
-                            GLuint depth0,
-                            bool for_bo);
+                            GLuint depth0);
 
 struct intel_mipmap_tree *
 intel_miptree_create_for_bo(struct intel_context *intel,
index 5ab60d16173cd26e3e64ddd55b1de41ef580fe85..63ef08b44a634771c1e12baad5daa0133e112f7f 100644 (file)
@@ -241,8 +241,7 @@ intel_set_texture_image_region(struct gl_context *ctx,
 
    intel_image->mt = intel_miptree_create_layout(intel, target, image->TexFormat,
                                                  0, 0,
-                                                 width, height, 1,
-                                                 true);
+                                                 width, height, 1);
    if (intel_image->mt == NULL)
        return;
    intel_region_reference(&intel_image->mt->region, region);