re PR c++/12774 (Type checking problems in templates)

cp:
	PR c++/12774
	* typeck.c (comp_array_types): Fold non-dependent domains for
	ABI-1.
testsuite:
	PR c++/12774
	* g++.dg/template/array1-1.C: New test.
	* g++.dg/template/array1-2.C: New test.

From-SVN: r75204

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 72c0f5f9bc2d4edc856ab9e5a0c39d278ff3e554..1d61141af0423f3a11db200607282e94fad2b3a2 100644 (file)
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,9 @@
+2003-12-29  Nathan Sidwell  <nathan@codesourcery.com>
+
+       PR c++/12774
+       * typeck.c (comp_array_types): Fold non-dependent domains for
+       ABI-1.
+
 2003-12-29  Kriang Lerdsuwanakij  <lerdsuwa@users.sourceforge.net>
 
        PR c++/13289

diff --git a/gcc/cp/typeck.c b/gcc/cp/typeck.c
index 3cdfdc297d8404afd31429f0bc6b04f475372a67..ff397c0417d0d36e2b21ff946347580b92882cbe 100644 (file)
--- a/gcc/cp/typeck.c
+++ b/gcc/cp/typeck.c
@@ -857,6 +857,7 @@ comp_array_types (tree t1, tree t2, bool allow_redeclaration)
 {
   tree d1;
   tree d2;
+  tree max1, max2;
 
   if (t1 == t2)
     return true;
@@ -887,8 +888,27 @@ comp_array_types (tree t1, tree t2, bool allow_redeclaration)
     return allow_redeclaration;
 
   /* Check that the dimensions are the same.  */
-  return (cp_tree_equal (TYPE_MIN_VALUE (d1), TYPE_MIN_VALUE (d2))
-         && cp_tree_equal (TYPE_MAX_VALUE (d1), TYPE_MAX_VALUE (d2)));
+
+  if (!cp_tree_equal (TYPE_MIN_VALUE (d1), TYPE_MIN_VALUE (d2)))
+    return false;
+  max1 = TYPE_MAX_VALUE (d1);
+  max2 = TYPE_MAX_VALUE (d2);
+  if (processing_template_decl && !abi_version_at_least (2)
+      && !value_dependent_expression_p (max1)
+      && !value_dependent_expression_p (max2))
+    {
+      /* With abi-1 we do not fold non-dependent array bounds, (and
+         consequently mangle them incorrectly).  We must therefore
+         fold them here, to verify the domains have the same
+         value.  */
+      max1 = fold (max1);
+      max2 = fold (max2);
+    }
+
+  if (!cp_tree_equal (max1, max2))
+    return false;
+
+  return true;
 }
 
 /* Return true if T1 and T2 are related as allowed by STRICT.  STRICT

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 9f575579a120bc9a9d1e885dc857bcde74613800..be64671bf901001a7eceda761c47cbc099dbabf4 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2003-12-29  Nathan Sidwell  <nathan@codesourcery.com>
+
+       PR c++/12774
+       * g++.dg/template/array1-1.C: New test.
+       * g++.dg/template/array1-2.C: New test.
+
 2003-12-29  Roger Sayle  <roger@eyesopen.com>
 
        PR fortran/12632

diff --git a/gcc/testsuite/g++.dg/template/array1-1.C b/gcc/testsuite/g++.dg/template/array1-1.C
new file mode 100644 (file)
index 0000000..97fe7cd
--- /dev/null
+++ b/gcc/testsuite/g++.dg/template/array1-1.C
@@ -0,0 +1,32 @@
+// { dg-do compile }
+// { dg-options "-fabi-version=1" }
+
+// Contributed by Nathan Sidwell 22 Dec 2003 <nathan@codesourcery.com>
+// Origin: Roger Sayle  <roger@eyesopen.com>
+
+// PR c++/12774 Array domains compared unequal
+
+void Foo(double r[3][3])
+{
+}
+
+void Baz()
+{
+   double m[3][3];
+   Foo(m);
+}
+
+template <class T>
+void Bar()
+{
+   double m[3][3];
+   Foo(m);
+}
+
+int main()
+{
+   Baz();
+   Bar<int>();
+   return 0;
+}
+

diff --git a/gcc/testsuite/g++.dg/template/array1-2.C b/gcc/testsuite/g++.dg/template/array1-2.C
new file mode 100644 (file)
index 0000000..7214517
--- /dev/null
+++ b/gcc/testsuite/g++.dg/template/array1-2.C
@@ -0,0 +1,32 @@
+// { dg-do compile }
+// { dg-options "-fabi-version=2" }
+
+// Contributed by Nathan Sidwell 22 Dec 2003 <nathan@codesourcery.com>
+// Origin: Roger Sayle  <roger@eyesopen.com>
+
+// PR c++/12774 Array domains compared unequal
+
+void Foo(double r[3][3])
+{
+}
+
+void Baz()
+{
+   double m[3][3];
+   Foo(m);
+}
+
+template <class T>
+void Bar()
+{
+   double m[3][3];
+   Foo(m);
+}
+
+int main()
+{
+   Baz();
+   Bar<int>();
+   return 0;
+}
+