re PR middle-end/56917 (-ftrapv detects a overflow wrongly.)

	PR middle-end/56917
	* fold-const.c (fold_unary_loc): Perform the negation in A's type
	when transforming ~ (A - 1) or ~ (A + -1) to -A.

	* c-c++-common/ubsan/pr56917.c: New test.

From-SVN: r218395

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 056ced259cf49e96d27b7575f82191542a02bd30..2d41d93b171d5379571a70809dbd3dd754315e9c 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2014-12-04  Marek Polacek  <polacek@redhat.com>
+
+       PR middle-end/56917
+       * fold-const.c (fold_unary_loc): Perform the negation in A's type
+       when transforming ~ (A - 1) or ~ (A + -1) to -A.
+
 2014-12-04  Tobias Burnus  <burnus@net-b.de>
 
        * Makefile.in: Remove CLOOGLIB and CLOOGINC.

diff --git a/gcc/fold-const.c b/gcc/fold-const.c
index 17eb5bb9f0f5f4ad098b4bf299bab5675f2d8de6..c268007415cd1d044defadfd6f5d3d69dcafb257 100644 (file)
--- a/gcc/fold-const.c
+++ b/gcc/fold-const.c
@@ -8141,9 +8141,14 @@ fold_unary_loc (location_t loc, enum tree_code code, tree type, tree op0)
                    && integer_onep (TREE_OPERAND (arg0, 1)))
                   || (TREE_CODE (arg0) == PLUS_EXPR
                       && integer_all_onesp (TREE_OPERAND (arg0, 1)))))
-       return fold_build1_loc (loc, NEGATE_EXPR, type,
-                           fold_convert_loc (loc, type,
-                                             TREE_OPERAND (arg0, 0)));
+       {
+         /* Perform the negation in ARG0's type and only then convert
+            to TYPE as to avoid introducing undefined behavior.  */
+         tree t = fold_build1_loc (loc, NEGATE_EXPR,
+                                   TREE_TYPE (TREE_OPERAND (arg0, 0)),
+                                   TREE_OPERAND (arg0, 0));
+         return fold_convert_loc (loc, type, t);
+       }
       /* Convert ~(X ^ Y) to ~X ^ Y or X ^ ~Y if ~X or ~Y simplify.  */
       else if (TREE_CODE (arg0) == BIT_XOR_EXPR
               && (tem = fold_unary_loc (loc, BIT_NOT_EXPR, type,

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index a0a78dc62b1d4bfe7189de393e7315fd2cf42606..0b3a9d682a92593ca9f2ad884ed6365556a514be 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2014-12-04  Marek Polacek  <polacek@redhat.com>
+
+       PR middle-end/56917
+       * c-c++-common/ubsan/pr56917.c: New test.
+
 2014-12-04  Martin Jambor  <mjambor@suse.cz>
 
        * gcc.dg/ipa/propalign-1.c: New test.

diff --git a/gcc/testsuite/c-c++-common/ubsan/pr56917.c b/gcc/testsuite/c-c++-common/ubsan/pr56917.c
new file mode 100644 (file)
index 0000000..cfbae97
--- /dev/null
+++ b/gcc/testsuite/c-c++-common/ubsan/pr56917.c
@@ -0,0 +1,34 @@
+/* PR middle-end/56917 */
+/* { dg-do run } */
+/* { dg-options "-fsanitize=undefined -fno-sanitize-recover=undefined" } */
+
+#define INT_MIN (-__INT_MAX__ - 1)
+#define LONG_MIN (-__LONG_MAX__ - 1L)
+#define LLONG_MIN (-__LONG_LONG_MAX__ - 1LL)
+
+int __attribute__ ((noinline,noclone))
+fn1 (unsigned int u)
+{
+  return (-(int) (u - 1U)) - 1;
+}
+
+long __attribute__ ((noinline,noclone))
+fn2 (unsigned long int ul)
+{
+  return (-(long) (ul - 1UL)) - 1L;
+}
+
+long long __attribute__ ((noinline,noclone))
+fn3 (unsigned long long int ull)
+{
+  return (-(long long) (ull - 1ULL)) - 1LL;
+}
+
+int
+main (void)
+{
+  if (fn1 (__INT_MAX__ + 1U) != INT_MIN
+      || fn2 (__LONG_MAX__ + 1UL) != LONG_MIN
+      || fn3 (__LONG_LONG_MAX__ + 1ULL) != LLONG_MIN)
+    __builtin_abort ();
+}