target.h: Expands complete_target_initialization and add_target comments.

Expand a bit the comments to answer some questions I had when looking
at why a target of mine would not have some default methods set.

gdb/ChangeLog:

        * target.h (complete_target_initialization, add_target):
        Add comment.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index fe176740119b14d316f9a78af690b92c0538409f..ff962d406161d9dd0d90af6f761ec84dc095bd05 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2014-03-07  Joel Brobecker  <brobecker@adacore.com>
+
+       * target.h (complete_target_initialization, add_target):
+       Add comment.
+
 2014-03-07  Pedro Alves  <palves@redhat.com>
 
        * go32-nat.c: Include inf-child.h.

diff --git a/gdb/target.h b/gdb/target.h
index 91f0cc96a3be3f09ae29b71310506ba238a64871..db9f5c35cc0cb43c7a165c3b61c063aebaf514b3 100644 (file)
--- a/gdb/target.h
+++ b/gdb/target.h
@@ -2006,9 +2006,13 @@ int target_verify_memory (const gdb_byte *data,
 /* Routines for maintenance of the target structures...
 
    complete_target_initialization: Finalize a target_ops by filling in
-   any fields needed by the target implementation.
+   any fields needed by the target implementation.  Unnecessary for
+   targets which are registered via add_target, as this part gets
+   taken care of then.
 
    add_target:   Add a target to the list of all possible targets.
+   This only makes sense for targets that should be activated using
+   the "target TARGET_NAME ..." command.
 
    push_target:  Make this target the top of the stack of currently used
    targets, within its particular stratum of the stack.  Result