[gdb/testsuite] Remove Dwarf::extern

The file lib/dwarf.exp contains:
...
    # Declare a global label.  This is typically used to refer to
    # labels defined in other files, for example a function defined in
    # a .c file.
    proc extern {args} {
	foreach name $args {
	    _op .global $name
	}
    }
...

The assembler directive to refer to labels defined in other files is
not .global, but .extern, and that one is ignored by gas.

Since we require gas for all dwarf assembly test-cases, remove the proc and
all it's uses.

Tested on x86_64-linux.

gdb/testsuite/ChangeLog:

2020-07-17  Tom de Vries  <tdevries@suse.de>

	* lib/dwarf.exp (Dwarf::extern): Remove.
	* gdb.compile/compile-ops.exp: Remove use of Dwarf::extern.
	* gdb.dlang/circular.exp: Same.
	* gdb.dwarf2/comp-unit-lang.exp: Same.
	* gdb.dwarf2/dw2-ifort-parameter.exp: Same.
	* gdb.dwarf2/dw2-symtab-includes.exp: Same.
	* gdb.dwarf2/dwz.exp: Same.
	* gdb.dwarf2/imported-unit-abstract-const-value.exp: Same.
	* gdb.dwarf2/imported-unit-runto-main.exp: Same.
	* gdb.dwarf2/imported-unit.exp: Same.
	* gdb.dwarf2/opaque-type-lookup.exp: Same.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index e20e0266970cdcd7cc298b512f09bd86d73369e5..76ad9657d45bb797421123ba8beda884847b3c54 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,17 @@
+2020-07-17  Tom de Vries  <tdevries@suse.de>
+
+       * lib/dwarf.exp (Dwarf::extern): Remove.
+       * gdb.compile/compile-ops.exp: Remove use of Dwarf::extern.
+       * gdb.dlang/circular.exp: Same.
+       * gdb.dwarf2/comp-unit-lang.exp: Same.
+       * gdb.dwarf2/dw2-ifort-parameter.exp: Same.
+       * gdb.dwarf2/dw2-symtab-includes.exp: Same.
+       * gdb.dwarf2/dwz.exp: Same.
+       * gdb.dwarf2/imported-unit-abstract-const-value.exp: Same.
+       * gdb.dwarf2/imported-unit-runto-main.exp: Same.
+       * gdb.dwarf2/imported-unit.exp: Same.
+       * gdb.dwarf2/opaque-type-lookup.exp: Same.
+
 2020-07-16  Sandra Loosemore  <sandra@codesourcery.com>
 
        * gdb.base/shell.exp: Skip pipe tests dependent on sh on Windows host.

diff --git a/gdb/testsuite/gdb.compile/compile-ops.exp b/gdb/testsuite/gdb.compile/compile-ops.exp
index d9aee413a6e62018967111732a0b63929c729e23..7c801d932c2197172d3c2788b7eea0135aa62b56 100644 (file)
--- a/gdb/testsuite/gdb.compile/compile-ops.exp
+++ b/gdb/testsuite/gdb.compile/compile-ops.exp
@@ -362,7 +362,6 @@ Dwarf::assemble $asm_file {
     cu { addr_size 4 } {
 
        declare_labels int_label
-       extern func_start func_end ptr
 
        compile_unit {
            {name file1.txt}

diff --git a/gdb/testsuite/gdb.dlang/circular.exp b/gdb/testsuite/gdb.dlang/circular.exp
index f3d8f6046938a4babbe6b58658cd06867a359758..1e04370478a01ff437c9b65f8538ee794f54a4f1 100644 (file)
--- a/gdb/testsuite/gdb.dlang/circular.exp
+++ b/gdb/testsuite/gdb.dlang/circular.exp
@@ -37,8 +37,6 @@ Dwarf::assemble $asm_file {
            declare_labels circular1_label circular2_label circular3_label
            declare_labels circular4_label circular5_label
 
-           extern circular1_found_start circular1_found_end
-
            circular1_label: module {
                {name circular1}
            } {

diff --git a/gdb/testsuite/gdb.dwarf2/comp-unit-lang.exp b/gdb/testsuite/gdb.dwarf2/comp-unit-lang.exp
index 8ff6b733cc97e8282e3f27b19785bf1b9082748a..2ebe6caedc3bc1a166acc9e65eeb31d2753a5853 100644 (file)
--- a/gdb/testsuite/gdb.dwarf2/comp-unit-lang.exp
+++ b/gdb/testsuite/gdb.dwarf2/comp-unit-lang.exp
@@ -42,8 +42,6 @@ proc do_test {cu_lang gdb_lang} {
        # Creating a CU with 4-byte addresses lets this test link on
        # both 32- and 64-bit machines.
        cu { addr_size 4 } {
-           extern func_start func_end
-
            compile_unit {
                {name file1.txt}
                {language @$cu_lang}

diff --git a/gdb/testsuite/gdb.dwarf2/dw2-ifort-parameter.exp b/gdb/testsuite/gdb.dwarf2/dw2-ifort-parameter.exp
index 75f17c5192e9e386dd4eeba9c273e3c407201177..2388ce53f6ed28253f4f92bf455fa349eb0772b7 100644 (file)
--- a/gdb/testsuite/gdb.dwarf2/dw2-ifort-parameter.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-ifort-parameter.exp
@@ -29,7 +29,6 @@ set asm_file [standard_output_file $srcfile2]
 Dwarf::assemble $asm_file {
     declare_labels int_label
 
-    extern func_start func_end ptr
     global srcdir subdir srcfile
 
     cu {} {

diff --git a/gdb/testsuite/gdb.dwarf2/dw2-symtab-includes.exp b/gdb/testsuite/gdb.dwarf2/dw2-symtab-includes.exp
index 1eaaf4af4fac50c85ebdf24f479c8ae47914cb54..e10e4130358cedcfc17f0b362a75d7315a6a1d3f 100644 (file)
--- a/gdb/testsuite/gdb.dwarf2/dw2-symtab-includes.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-symtab-includes.exp
@@ -31,8 +31,6 @@ Dwarf::assemble $asm_file {
     declare_labels partial_label lines_label
     global srcdir subdir srcfile
 
-    extern main
-
     cu {} {
        partial_label: partial_unit {} {
        }

diff --git a/gdb/testsuite/gdb.dwarf2/dwz.exp b/gdb/testsuite/gdb.dwarf2/dwz.exp
index b9987ed0d11e5119091b599eca17a3835cc7f900..9f5eda5e381165824f6b4c0c430a0c892029008d 100644 (file)
--- a/gdb/testsuite/gdb.dwarf2/dwz.exp
+++ b/gdb/testsuite/gdb.dwarf2/dwz.exp
@@ -28,8 +28,6 @@ Dwarf::assemble $asm_file {
     declare_labels partial_label int_label int_label2
     global srcdir subdir srcfile
 
-    extern main
-
     cu {} {
        partial_label: partial_unit {} {
            subprogram {

diff --git a/gdb/testsuite/gdb.dwarf2/imported-unit-abstract-const-value.exp b/gdb/testsuite/gdb.dwarf2/imported-unit-abstract-const-value.exp
index f93dc123885f7f3b7c75f6013f4036ce78f129ae..13a7e97cc56376f6dc932e616a59abc6c46bee2f 100644 (file)
--- a/gdb/testsuite/gdb.dwarf2/imported-unit-abstract-const-value.exp
+++ b/gdb/testsuite/gdb.dwarf2/imported-unit-abstract-const-value.exp
@@ -42,8 +42,6 @@ Dwarf::assemble $asm_file {
 
     global srcdir subdir srcfile
 
-    extern main
-
     set main_range [function_range main ${srcdir}/${subdir}/${srcfile}]
     set main_start [lindex $main_range 0]
     set main_length [lindex $main_range 1]

diff --git a/gdb/testsuite/gdb.dwarf2/imported-unit-runto-main.exp b/gdb/testsuite/gdb.dwarf2/imported-unit-runto-main.exp
index 279468405342febb1da85ac6636a3af3d37cc43b..8a05ee852709023cb6995dd267910661ba646d79 100644 (file)
--- a/gdb/testsuite/gdb.dwarf2/imported-unit-runto-main.exp
+++ b/gdb/testsuite/gdb.dwarf2/imported-unit-runto-main.exp
@@ -39,8 +39,6 @@ Dwarf::assemble $asm_file {
 
     global srcdir subdir srcfile
 
-    extern main
-
     set main_range [function_range main ${srcdir}/${subdir}/${srcfile}]
     set main_start [lindex $main_range 0]
     set main_length [lindex $main_range 1]

diff --git a/gdb/testsuite/gdb.dwarf2/imported-unit.exp b/gdb/testsuite/gdb.dwarf2/imported-unit.exp
index 32a9abf6204d518111c55c7f6de51aa62169567c..dba87ffcb2cf3a8dc9ea4456cfc5e9c2228764fe 100644 (file)
--- a/gdb/testsuite/gdb.dwarf2/imported-unit.exp
+++ b/gdb/testsuite/gdb.dwarf2/imported-unit.exp
@@ -56,9 +56,6 @@ Dwarf::assemble $asm_file {
 
     global srcdir subdir srcfile
 
-    extern main
-    extern doit
-
     set main_range [function_range main ${srcdir}/${subdir}/${srcfile}]
     set main_start [lindex $main_range 0]
     set main_length [lindex $main_range 1]

diff --git a/gdb/testsuite/gdb.dwarf2/opaque-type-lookup.exp b/gdb/testsuite/gdb.dwarf2/opaque-type-lookup.exp
index 60d67b1bda34a6d7065da9ef63f622f1895f5ef0..19316ef7eb7e0f6053bc6f25719e636d4f4d14df 100644 (file)
--- a/gdb/testsuite/gdb.dwarf2/opaque-type-lookup.exp
+++ b/gdb/testsuite/gdb.dwarf2/opaque-type-lookup.exp
@@ -34,8 +34,6 @@ Dwarf::assemble $asm_file {
     declare_labels char_type1_label char_type2_label
     global srcdir subdir srcfile
 
-    extern main
-
     # The partial units are laid out so we're not dependent on the order that
     # they appear in compunit_symtab.includes.  We need the one with the
     # opaque definition to appear first to gdb, so we put it in the middle.

diff --git a/gdb/testsuite/lib/dwarf.exp b/gdb/testsuite/lib/dwarf.exp
index 21dc0f62d4da0302b091fc9ac50801ff295738e3..f745b2ae313845a6114ea8ca097958072314575a 100644 (file)
--- a/gdb/testsuite/lib/dwarf.exp
+++ b/gdb/testsuite/lib/dwarf.exp
@@ -822,15 +822,6 @@ namespace eval Dwarf {
        _emit "${name}:"
     }
 
-    # Declare a global label.  This is typically used to refer to
-    # labels defined in other files, for example a function defined in
-    # a .c file.
-    proc extern {args} {
-       foreach name $args {
-           _op .global $name
-       }
-    }
-
     # A higher-level interface to label handling.
     #
     # ARGS is a list of label descriptors.  Each one is either a