Specialize value_cast error message for Ada

In Ada, the term for a cast is "type conversion".  AdaCore has been
carrying a local patch to specialize the error message in value_cast,
but it seemed fine to me for this to be part of gdb.  This also
removes a dead "return" statement.

gdb/ChangeLog
2019-07-10  Tom Tromey  <tromey@adacore.com>

	* valops.c (value_cast): Specialize error message for Ada.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c4db1960d3b6bde656ccc30a45e97f1b1ac9e782..410a8d803cf425af572beae14323fa607c9022b5 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2019-07-10  Tom Tromey  <tromey@adacore.com>
+
+       * valops.c (value_cast): Specialize error message for Ada.
+
 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 
        * breakpoint.c (breakpoint_1): Update doc and parameter names.

diff --git a/gdb/valops.c b/gdb/valops.c
index 663edae20340ed48f706618b49b238af5a78fd8c..82b54561c244b2d420f3cf718c3bec83e251bacf 100644 (file)
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -555,8 +555,9 @@ value_cast (struct type *type, struct value *arg2)
     return value_at_lazy (to_type, value_address (arg2));
   else
     {
+      if (current_language->la_language == language_ada)
+       error (_("Invalid type conversion."));
       error (_("Invalid cast."));
-      return 0;
     }
 }