Remove checks of the return value from bfd_cache_ookup()

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 554e3b4b16763d3c4ba7c5d736c4807f9c652280..d8b366621464d8870604fe4caa8192ea53dcac33 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -4,6 +4,10 @@
        * cache.c (bfd_cache_lookup_worker): Call abort() rather than
        returning NULL as most users of this function do not check its
        return value.
+       * hppabsd-core.c (hppabsd_core_core_file_p): Do not check result
+       of bfd_cache_lookup().
+       * sco5-core.c (sco5_core_file_p): Likewise.
+       * trad-core.c (trad_unix_core_file_p): Likewise.
 
 2004-05-05  Nick Clifton  <nickc@redhat.com>
 

diff --git a/bfd/hppabsd-core.c b/bfd/hppabsd-core.c
index ff88f9d2273bc69c4f4af9d80a0cb86e6ca29136..be07c78ce9296db18ee916ba12045c1d1b2d8788 100644 (file)
--- a/bfd/hppabsd-core.c
+++ b/bfd/hppabsd-core.c
@@ -139,7 +139,8 @@ hppabsd_core_core_file_p (abfd)
   {
     FILE *stream = bfd_cache_lookup (abfd);
     struct stat statbuf;
-    if (stream == NULL || fstat (fileno (stream), &statbuf) < 0)
+
+    if (fstat (fileno (stream), &statbuf) < 0)
       {
        bfd_set_error (bfd_error_system_call);
        return NULL;

diff --git a/bfd/sco5-core.c b/bfd/sco5-core.c
index 5c34ff1b5562612215fb4247f9192d268587dd77..b88bd7b1af37b25ea4e5fe2c7de3126ad9c7cb84 100644 (file)
--- a/bfd/sco5-core.c
+++ b/bfd/sco5-core.c
@@ -123,13 +123,12 @@ sco5_core_file_p (abfd)
   char *secname;
   flagword flags;
 
-  /* Read coreoffsets region at end of core (see core(FP)) */
+  /* Read coreoffsets region at end of core (see core(FP)).  */
 
   {
     FILE *stream = bfd_cache_lookup (abfd);
     struct stat statbuf;
-    if (stream == NULL)
-      return NULL;
+
     if (fstat (fileno (stream), &statbuf) < 0)
       {
        bfd_set_error (bfd_error_system_call);

diff --git a/bfd/trad-core.c b/bfd/trad-core.c
index f8c03d739a8f045b15ed3aa91e8b827cf7c7586e..1b9e69f2a91bcfcc50c18628ec011e3e18486398 100644 (file)
--- a/bfd/trad-core.c
+++ b/bfd/trad-core.c
@@ -111,8 +111,7 @@ trad_unix_core_file_p (abfd)
   {
     FILE *stream = bfd_cache_lookup (abfd);
     struct stat statbuf;
-    if (stream == NULL)
-      return 0;
+
     if (fstat (fileno (stream), &statbuf) < 0)
       {
        bfd_set_error (bfd_error_system_call);