Add new GCC 9 warnings to warnings.m4

GCC 9 has a few new warnings that aren't enabled in the gdb build by
default: -Wdeprecated-copy, -Wdeprecated-copy-dtor, and
-Wredundant-move.  This patch enables them all.

Tested by rebuilding with a new GCC (git master) on x86-64 Fedora 29.

gdb/ChangeLog
2019-05-29  Tom Tromey  <tromey@adacore.com>

	* inflow.c (struct terminal_info): Add default operator=.
	* configure: Rebuild.
	* warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
	-Wdeprecated-copy-dtor, -Wredundant-move.

gdb/gdbserver/ChangeLog
2019-05-29  Tom Tromey  <tromey@adacore.com>

	* configure: Rebuild.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 16c1d0c844e9481b8568e82a900a54a9e2c869ef..c105fb7b0a74ed5061b94d34590b4a420aff786f 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2019-05-29  Tom Tromey  <tromey@adacore.com>
+
+       * inflow.c (struct terminal_info): Add default operator=.
+       * configure: Rebuild.
+       * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
+       -Wdeprecated-copy-dtor, -Wredundant-move.
+
 2019-05-29  Tom Tromey  <tromey@adacore.com>
 
        * NEWS: Add entry.

diff --git a/gdb/configure b/gdb/configure
index 15a96afcca8a5cc34957896eca572d63ecaadee9..ff0971bc2876b753b590e39576aaf8a2d330eada 100755 (executable)
--- a/gdb/configure
+++ b/gdb/configure
@@ -15436,7 +15436,10 @@ build_warnings="-Wall -Wpointer-arith \
 -Wsuggest-override \
 -Wimplicit-fallthrough=3 \
 -Wduplicated-cond \
--Wshadow=local"
+-Wshadow=local \
+-Wdeprecated-copy \
+-Wdeprecated-copy-dtor \
+-Wredundant-move"
 
 case "${host}" in
   *-*-mingw32*)

diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index 2e98158aa6f4ab7e731792269292a7dc77a8479a..e15395d695431e5bb540453184ba66e726827dcf 100644 (file)
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,7 @@
+2019-05-29  Tom Tromey  <tromey@adacore.com>
+
+       * configure: Rebuild.
+
 2019-05-06  Kevin Buettner  <kevinb@redhat.com>
 
        * linux-x86-low.c (x86_fill_gregset): Don't compile 64-bit

diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure
index 1ddbd6b27e0adcd825f467f377accf2eabfc3b4a..5ffdeb0816bb763deedd1672844562f025b2e36b 100755 (executable)
--- a/gdb/gdbserver/configure
+++ b/gdb/gdbserver/configure
@@ -7271,7 +7271,10 @@ build_warnings="-Wall -Wpointer-arith \
 -Wsuggest-override \
 -Wimplicit-fallthrough=3 \
 -Wduplicated-cond \
--Wshadow=local"
+-Wshadow=local \
+-Wdeprecated-copy \
+-Wdeprecated-copy-dtor \
+-Wredundant-move"
 
 case "${host}" in
   *-*-mingw32*)

diff --git a/gdb/inflow.c b/gdb/inflow.c
index eba7a931f467c3f97e1006136c3618941bc015fb..621f69aa40fbe7f2753b9e0de2730a1f9f19af9f 100644 (file)
--- a/gdb/inflow.c
+++ b/gdb/inflow.c
@@ -61,6 +61,8 @@ struct terminal_info
   terminal_info () = default;
   ~terminal_info ();
 
+  terminal_info &operator= (const terminal_info &) = default;
+
   /* The name of the tty (from the `tty' command) that we gave to the
      inferior when it was started.  */
   char *run_terminal = nullptr;

diff --git a/gdb/warning.m4 b/gdb/warning.m4
index 98eb4ce7878c8beb4f9f31cd3d29f0a1c49210e7..c9e64a1836a8e01339ca4e3c3d689657ff9ef92c 100644 (file)
--- a/gdb/warning.m4
+++ b/gdb/warning.m4
@@ -46,7 +46,10 @@ build_warnings="-Wall -Wpointer-arith \
 -Wsuggest-override \
 -Wimplicit-fallthrough=3 \
 -Wduplicated-cond \
--Wshadow=local"
+-Wshadow=local \
+-Wdeprecated-copy \
+-Wdeprecated-copy-dtor \
+-Wredundant-move"
 
 case "${host}" in
   *-*-mingw32*)