amd/addrlib: fix missing va_end() after va_copy()
authorNicolai Hähnle <nicolai.haehnle@amd.com>
Wed, 20 Sep 2017 14:43:00 +0000 (16:43 +0200)
committerNicolai Hähnle <nicolai.haehnle@amd.com>
Thu, 21 Sep 2017 08:59:36 +0000 (10:59 +0200)
There's no reason to use va_copy here.

CID: 1418113
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
Fixes: e7fc664b91a5d886c270 ("winsys/amdgpu: add addrlib - texture
                              addressing and alignment calculator")
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
src/amd/addrlib/core/addrobject.cpp

index dcdb1bffc2bde4771636165de9860115cab5ebac..452feb5fac0fbd6404bc74ec8ed746e8f89bf903 100644 (file)
@@ -216,20 +216,16 @@ VOID Object::DebugPrint(
 #if DEBUG
     if (m_client.callbacks.debugPrint != NULL)
     {
-        va_list ap;
-
-        va_start(ap, pDebugString);
-
         ADDR_DEBUGPRINT_INPUT debugPrintInput = {0};
 
         debugPrintInput.size         = sizeof(ADDR_DEBUGPRINT_INPUT);
         debugPrintInput.pDebugString = const_cast<CHAR*>(pDebugString);
         debugPrintInput.hClient      = m_client.handle;
-        va_copy(debugPrintInput.ap, ap);
+        va_start(debugPrintInput.ap, pDebugString);
 
         m_client.callbacks.debugPrint(&debugPrintInput);
 
-        va_end(ap);
+        va_end(debugPrintInput.ap);
     }
 #endif
 }