Check asprintf return value

git a31b8bd9a05 introduced a warning (depending on your system
headers).

	PR 24225
	* elf32-nios2.c (nios2_elf32_relocate_section): Check asprintf
	return value.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index bb73a972759da5b53019f4d1423b4afa9737c836..81836783a04cb0e52894bbd79e6beff448809a78 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2019-02-20  Alan Modra  <amodra@gmail.com>
+
+       PR 24225
+       * elf32-nios2.c (nios2_elf32_relocate_section): Check asprintf
+       return value.
+
 2019-02-20  Michael Roitzsch  <reactorcontrol@icloud.com>
 
        * configure.ac (SHARED_LIBADD): Add -liberty -lintl for all

diff --git a/bfd/elf32-nios2.c b/bfd/elf32-nios2.c
index b0f200d0f8efdbd54ce96e06d37c328d20af16b5..5d787eb2f4010692fe23121eb8f73e6d60cd8278 100644 (file)
--- a/bfd/elf32-nios2.c
+++ b/bfd/elf32-nios2.c
@@ -3821,7 +3821,9 @@ nios2_elf32_relocate_section (bfd *output_bfd,
 
                  format = _("global pointer relative relocation at address "
                             "%#" PRIx64 " when _gp not defined\n");
-                 asprintf (&msgbuf, format, (uint64_t) reloc_address);
+                 if (asprintf (&msgbuf, format,
+                               (uint64_t) reloc_address) == -1)
+                   msgbuf = NULL;
                  msg = msgbuf;
                  r = bfd_reloc_dangerous;
                }
@@ -3851,9 +3853,10 @@ nios2_elf32_relocate_section (bfd *output_bfd,
                                 "the global pointer (at %#" PRIx64 ") "
                                 "because the offset (%" PRId64 ") is out of "
                                 "the allowed range, -32678 to 32767\n" );
-                     asprintf (&msgbuf, format, name,
-                               (uint64_t) symbol_address, (uint64_t) gp,
-                               (int64_t) relocation);
+                     if (asprintf (&msgbuf, format, name,
+                                   (uint64_t) symbol_address, (uint64_t) gp,
+                                   (int64_t) relocation) == -1)
+                       msgbuf = NULL;
                      msg = msgbuf;
                      r = bfd_reloc_outofrange;
                    }