spirv: Allow block-decorated struct types for constants
authorJason Ekstrand <jason@jlekstrand.net>
Fri, 10 Jul 2020 20:58:39 +0000 (15:58 -0500)
committerMarge Bot <eric+marge@anholt.net>
Sun, 12 Jul 2020 00:02:45 +0000 (00:02 +0000)
Whenever a struct type is decorated Block or BufferBlock we turn that
into a GLSL_TYPE_INTERFACE.  Since these decorations can end up random
places, we should allow them for constants.

Closes: #3252
Fixes: 9d0ae777dd6 "spirv: Use interface type for block and buffer..."
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5855>

src/compiler/nir/nir_print.c
src/compiler/spirv/spirv_to_nir.c

index e83d411f2951c3936d2bae2bda4bff91830b8c6d..fe73746c334520a4cf5859398fa8dd3d8c33fe63 100644 (file)
@@ -399,6 +399,7 @@ print_constant(nir_constant *c, const struct glsl_type *type, print_state *state
       break;
 
    case GLSL_TYPE_STRUCT:
+   case GLSL_TYPE_INTERFACE:
       for (i = 0; i < c->num_elements; i++) {
          if (i > 0) fprintf(fp, ", ");
          fprintf(fp, "{ ");
index 2e351cc21ed077c7f6c652dfa7a850a1e4e43517..b9f35ad0262627767134c0a3b82dc078f9667f87 100644 (file)
@@ -256,7 +256,8 @@ vtn_const_ssa_value(struct vtn_builder *b, nir_constant *constant,
       break;
    }
 
-   case GLSL_TYPE_STRUCT: {
+   case GLSL_TYPE_STRUCT:
+   case GLSL_TYPE_INTERFACE: {
       unsigned elems = glsl_get_length(val->type);
       val->elems = ralloc_array(b, struct vtn_ssa_value *, elems);
       for (unsigned i = 0; i < elems; i++) {