2007-07-25 Michael Snyder <msnyder@access-company.com>

	* coffgen.c (_bfd_coff_get_external_symbols): Nothing to be done
	if size == 0; return and avoid possible null pointer issues.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index d0f1e3f68b1ca8b9be90fd588a86ffaf1cfaf514..61c4ad7fba78acc5f97794d43dcdb98a8df24380 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2007-07-25  Michael Snyder  <msnyder@access-company.com>
+
+       * coffgen.c (_bfd_coff_get_external_symbols): Nothing to be done
+       if size == 0; return and avoid possible null pointer issues.
+
 2007-07-25  Alan Modra  <amodra@bigpond.net.au>
 
        * linker.c (generic_link_add_symbol_list): Warning fix.

diff --git a/bfd/coffgen.c b/bfd/coffgen.c
index 7430cf6a760f642cd352380c2c766d52d8e9e610..f4f97b3f0d798f853a6a9b61cb7e7bd4057e068c 100644 (file)
--- a/bfd/coffgen.c
+++ b/bfd/coffgen.c
@@ -1444,9 +1444,11 @@ _bfd_coff_get_external_symbols (bfd *abfd)
   symesz = bfd_coff_symesz (abfd);
 
   size = obj_raw_syment_count (abfd) * symesz;
+  if (size == 0)
+    return TRUE;
 
   syms = bfd_malloc (size);
-  if (syms == NULL && size != 0)
+  if (syms == NULL)
     return FALSE;
 
   if (bfd_seek (abfd, obj_sym_filepos (abfd), SEEK_SET) != 0