Issue error on erroneous expression

A while back I discovered that this does not issue an error:

    (gdb) p $x = (void * ) 57
    $3 = (void *) 0x39
    (gdb) p $x + 7 = 3
    $6 = (void *) 0x3

This patch fixes the bug.
Regression tested on x86-64 Fedora 36.

Reviewed-By: Bruno Larsen <blarsen@redhat.com>
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=19312

diff --git a/gdb/testsuite/gdb.base/gdbvars.exp b/gdb/testsuite/gdb.base/gdbvars.exp
index ced77aa15c43618a814a7aff9b018e05bbfede27..cb6656c176f648354b1e428680db992ae187960c 100644 (file)
--- a/gdb/testsuite/gdb.base/gdbvars.exp
+++ b/gdb/testsuite/gdb.base/gdbvars.exp
@@ -66,6 +66,14 @@ proc test_convenience_variables {} {
     gdb_test "print \$arr = {0, 1, 2, 3}" \
        " = \\{0, 1, 2, 3\\}" \
        "Set convenience variable to different array value"
+
+    gdb_test "print \$ptr = (void *) 7" \
+       " = \\(void \\*\\) 0x7" \
+       "set convenience variable to pointer value"
+    # This used to "succeed".
+    gdb_test "print \$ptr + 23 = 97" \
+       "Left operand of assignment is not an lvalue." \
+       "reject invalid assignment"
 }
 
 proc test_convenience_functions {} {

diff --git a/gdb/valarith.c b/gdb/valarith.c
index 0ab684aa05b1c09dc95052994fc09593a8957a5a..a6a5f5102a2f7e0207ff6f27dc1394f7fdf14c73 100644 (file)
--- a/gdb/valarith.c
+++ b/gdb/valarith.c
@@ -93,7 +93,7 @@ value_ptradd (struct value *arg1, LONGEST arg2)
 
   result = value_from_pointer (valptrtype,
                               value_as_address (arg1) + sz * arg2);
-  if (result->lval () != lval_internalvar)
+  if (arg1->lval () != lval_internalvar)
     result->set_component_location (arg1);
   return result;
 }