Various cleanup. Mostly forcing initialization of some fields...

I noticed that checkpoints dumped from m5.debug and m5.opt had
differences, which is no longer the case (other than addresses
encoded in names).

cpu/full_cpu/smt.hh:
    Get rid of unused SMT_MAX_CPUS.
sim/debug.cc:
    Use AutoDelete for DebugBreakEvent.
sim/serialize.cc:
sim/serialize.hh:
    Move constructor & destructor to header so they can be inlined.

--HG--
extra : convert_revision : bc68c2c9b053b1de0d655ed555734419fafd0b83

diff --git a/cpu/full_cpu/smt.hh b/cpu/full_cpu/smt.hh
index f9c1e46140f42517351b8b4fbcb48975e63d9c07..6a4151ffdbe28e240d3f870c49a80472d7ff170d 100644 (file)
--- a/cpu/full_cpu/smt.hh
+++ b/cpu/full_cpu/smt.hh
@@ -28,17 +28,12 @@
 
 /**
  * @file
- * Defines SMT_MAX_CPUS and SMT_MAX_THREADS.
+ * Defines SMT_MAX_THREADS.
  */
 
 #ifndef __SMT_HH__
 #define __SMT_HH__
 
-#ifndef SMT_MAX_CPUS
-/** The maximum number of cpus in any one system. */
-#define SMT_MAX_CPUS 4
-#endif
-
 #ifndef SMT_MAX_THREADS
 /** The number of TPUs in any processor. */
 #define SMT_MAX_THREADS 4

diff --git a/sim/debug.cc b/sim/debug.cc
index 95187baff10653c4cdc47abe4d5a6d94c45379e9..6f3789c96c0264cb27aaf01e50a8467ee3b02e58 100644 (file)
--- a/sim/debug.cc
+++ b/sim/debug.cc
@@ -66,6 +66,7 @@ class DebugBreakEvent : public Event
 DebugBreakEvent::DebugBreakEvent(EventQueue *q, Tick _when)
     : Event(q)
 {
+    setFlags(AutoDelete);
     schedule(_when, -20000);
 }
 
@@ -76,7 +77,6 @@ void
 DebugBreakEvent::process()
 {
     debug_break();
-    delete this;
 }
 
 

diff --git a/sim/serialize.cc b/sim/serialize.cc
index 1fce6e7b17a027a5e523d14e25206881dd496e7c..9738029c2132ecd903f73f54523a06452d530559 100644 (file)
--- a/sim/serialize.cc
+++ b/sim/serialize.cc
@@ -50,13 +50,6 @@ using namespace std;
 
 Serializer *Serializeable::serializer = NULL;
 
-Serializeable::Serializeable()
-    : serialized(false)
-{ }
-
-Serializeable::~Serializeable()
-{ }
-
 void
 Serializeable::mark()
 {

diff --git a/sim/serialize.hh b/sim/serialize.hh
index bc40d0ad2b95780758d4b9cc5d7281c4534ea521..077931d8c5dd16b70a48ca5b463c549d8d92252a 100644 (file)
--- a/sim/serialize.hh
+++ b/sim/serialize.hh
@@ -115,8 +115,8 @@ class Serializeable
     void nameOut(std::ostream& os, const std::string &_name);
 
   public:
-    Serializeable();
-    virtual ~Serializeable();
+    Serializeable() : serialized(false) {}
+    virtual ~Serializeable() {}
 
     // manditory virtual function, so objects must provide names
     virtual std::string name() const = 0;