mesa: Add notes about remaining NV_vertex_program code.
authorEric Anholt <eric@anholt.net>
Tue, 9 Oct 2012 23:38:56 +0000 (16:38 -0700)
committerEric Anholt <eric@anholt.net>
Mon, 15 Oct 2012 18:53:24 +0000 (11:53 -0700)
Reviewed-by: Brian Paul <brianp@vmware.com>
src/mesa/main/nvprogram.c
src/mesa/main/vtxfmt.c
src/mesa/vbo/vbo_exec_api.c

index 6ad846e377e6e00baed90936faa449a6b2e286cf..4b24dde39c6a4a6dba91a3501f565a21c55d8972 100644 (file)
@@ -205,6 +205,10 @@ _mesa_GetProgramStringNV(GLuint id, GLenum pname, GLubyte *program)
 
 /**
  * Get a vertex array attribute pointer.
+ *
+ * While the function first appeared in GL_NV_vertex_program, it's
+ * aliased for use by GL_ARB_vertex_program.
+ *
  * \note Not compiled into display lists.
  * \note Called from the GL API dispatcher.
  */
index aa6cf286a09a9e1e8157fbefb144b13d1089999e..462cc8849352716ec81a0137781697eb254484bd 100644 (file)
@@ -135,7 +135,7 @@ install_vtxfmt(struct gl_context *ctx, struct _glapi_table *tab,
                                                vfmt->DrawTransformFeedbackStreamInstanced);
    }
 
-   /* GL_NV_vertex_program */
+   /* Originally for GL_NV_vertex_program, this is also used by dlist.c */
    if (ctx->API == API_OPENGL) {
       SET_VertexAttrib1fNV(tab, vfmt->VertexAttrib1fNV);
       SET_VertexAttrib1fvNV(tab, vfmt->VertexAttrib1fvNV);
index 52b363da3e9ea8140adf2b92f687e21aa27960b4..2ddb715889e27336f5034abdd785b71d85bfc404 100644 (file)
@@ -958,6 +958,10 @@ static void vbo_exec_vtxfmt_init( struct vbo_exec_context *exec )
       vfmt->VertexAttrib4fvARB = vbo_VertexAttrib4fvARB;
    }
 
+   /* Note that VertexAttrib4fNV is used from dlist.c and api_arrayelt.c so
+    * they can have a single entrypoint for updating any of the legacy
+    * attribs.
+    */
    vfmt->VertexAttrib1fNV = vbo_VertexAttrib1fNV;
    vfmt->VertexAttrib1fvNV = vbo_VertexAttrib1fvNV;
    vfmt->VertexAttrib2fNV = vbo_VertexAttrib2fNV;