Fix cygwin build error

With "gcc version 10.2.0 (GCC)" on cygwin, I get this build error:
  CXX    windows-nat.o
In file included from ../../gdb/../gdbsupport/common-defs.h:129,
                 from ../../gdb/defs.h:28,
                 from ../../gdb/windows-nat.c:24:
../../gdb/windows-nat.c: In function 'void windows_init_thread_list()':
../../gdb/windows-nat.c:513:17: error: zero-length gnu_printf format string [-Werror=format-zero-length]
  513 |   DEBUG_EVENTS ("");
      |                 ^~
../../gdb/../gdbsupport/common-debug.h:65:43: note: in definition of macro 'debug_prefixed_printf_cond'
   65 |  debug_prefixed_printf (module, __func__, fmt, ##__VA_ARGS__); \
      |                                           ^~~
../../gdb/windows-nat.c:513:3: note: in expansion of macro 'DEBUG_EVENTS'
  513 |   DEBUG_EVENTS ("");
      |   ^~~~~~~~~~~~
cc1plus: all warnings being treated as errors

This was introduced in 4ef367bffd73d50002339deba40983530ccb9d15, which removed
the function name from this debug message:
-  DEBUG_EVENTS (("gdb: windows_init_thread_list\n"));
+  DEBUG_EVENTS ("");

DEBUG_EVENTS now always includes the function name, so just add a "called"
message to fix the compile error.

gdb/ChangeLog:

2021-03-16  Christian Biesinger  <cbiesinger@google.com>

	* windows-nat.c (windows_init_thread_list): Add message to
	debug log.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 2e4628b87c592f728b8057ff04fbfd08d467c2cb..7a824a8a0cc1eb6df33752d3882903656da5b018 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2021-03-16  Christian Biesinger  <cbiesinger@google.com>
+
+       * windows-nat.c (windows_init_thread_list): Add message to
+       debug log.
+
 2021-03-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 
        * python/py-framefilter.c (py_print_frame): Use PyInt_Check as

diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index 8f6fb3ddcdf5941badaf564c0f49b3d58aa356d5..c8275fc5420479988fd85d14de6ad571841ffb6a 100644 (file)
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -510,7 +510,7 @@ windows_add_thread (ptid_t ptid, HANDLE h, void *tlb, bool main_thread_p)
 static void
 windows_init_thread_list (void)
 {
-  DEBUG_EVENTS ("");
+  DEBUG_EVENTS ("called");
   init_thread_list ();
 
   for (windows_thread_info *here : thread_list)