gdb: clean up some inefficient std::string usage

This commit:

  commit 53cf95c3389a3ecd97276d322e4a60fe3396a201
  Date:   Wed Dec 14 14:17:44 2022 +0000

      gdb: make more use of make_target_connection_string

Introduced a couple of inefficient uses of std::string, both of which
are fixed in this commit.

There should be no user visible changes after this commit.

Approved-By: Simon Marchi <simon.marchi@efficios.com>

diff --git a/gdb/inferior.c b/gdb/inferior.c
index 3d2bce9df7bdec6e88e30d190268d1dd9bb02d50..928305fc79d0e447ced29566b6b0a8a0f3b35c5d 100644 (file)
--- a/gdb/inferior.c
+++ b/gdb/inferior.c
@@ -486,8 +486,7 @@ uiout_field_connection (process_stratum_target *proc_target)
     return {};
   else
     {
-      std::string conn_str
-       = make_target_connection_string (proc_target).c_str ();
+      std::string conn_str = make_target_connection_string (proc_target);
       return string_printf ("%d (%s)", proc_target->connection_number,
                            conn_str.c_str ());
     }

diff --git a/gdb/target-connection.c b/gdb/target-connection.c
index d88b9c8f5637764e029f33c2ebbb4d8959f282f9..55818cf28dca79593dfd3ae40edcdb6a3e489bcb 100644 (file)
--- a/gdb/target-connection.c
+++ b/gdb/target-connection.c
@@ -91,7 +91,7 @@ print_connection (struct ui_out *uiout, const char *requested_connections)
 
       process_stratum_target *t = it.second;
 
-      size_t l = strlen (make_target_connection_string (t).c_str ());
+      size_t l = make_target_connection_string (t).length ();
       if (l > what_len)
        what_len = l;
     }